Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename function to prevent conflict to debase #443

Conversation

tzmfreedom
Copy link
Contributor

@tzmfreedom tzmfreedom commented Mar 21, 2018

When we use byebug and debase gem simultaneously, there are conflict because extern function name is conflict each other.

For example, with byebug and debase gem, if we use byebug method to debug code, the following error is occured (this is the same issue as #200 #360 )

NoMethodError (undefined method `step_out' for #<Byebug::Context:0x007fa4608278d0>)

This is because both gem have extern function Init_context and context_create and if we call these function in byebug gem, it calls debase's function. (Maybe other development gem use these function name, because context is commonly used variable name)

This PR solve by renaming function.

@deivid-rodriguez
Copy link
Owner

Makes sense to me @tzmfreedom! I guess you could potentially bundle both debuggers (for example, debase for Rubymine, and byebug for direct debugging) and things should work. Can you add a change log entry for this under ### Fixed? I'll release byebug 10.0.1 with this fix.

tzmfreedom added a commit to tzmfreedom/byebug that referenced this pull request Mar 21, 2018
@@ -125,7 +125,7 @@ extern VALUE next_thread;

/* functions from context.c */
extern void Init_context(VALUE mByebug);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to replace this function as well, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your review. I fixed it.

@deivid-rodriguez deivid-rodriguez merged commit a3ffdcd into deivid-rodriguez:master Mar 21, 2018
@deivid-rodriguez
Copy link
Owner

Thank you @tzmfreedom!

This was referenced Mar 22, 2018
tzmfreedom added a commit to tzmfreedom/byebug that referenced this pull request Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants