fix: only allow enabling permissioned game types in opcmv2 deployment#835
Merged
0xiamflux merged 3 commits intosc-feat/opcm2-deploy-opc-gamesfrom Feb 2, 2026
Merged
Conversation
0xiamflux
reviewed
Feb 2, 2026
0xniha
commented
Feb 2, 2026
Comment on lines
+889
to
+892
| IDisputeGameFactory _dgf = IDisputeGameFactory(_input.sysCfg.disputeGameFactory()); | ||
| bool isInitialDeployment = address(_dgf.gameImpls(GameTypes.CANNON)) == address(0) | ||
| && address(_dgf.gameImpls(GameTypes.CANNON_KONA)) == address(0) | ||
| && address(_dgf.gameImpls(GameTypes.PERMISSIONED_CANNON)) != address(0); |
Author
There was a problem hiding this comment.
I don't like this check, I'm open to suggestions to replace it.
There was a problem hiding this comment.
Wouldn't assertValidPermissionlessDisputeGame just return early if those are zero addresses?
0xiamflux
previously approved these changes
Feb 2, 2026
0xiamflux
approved these changes
Feb 2, 2026
0xiamflux
pushed a commit
that referenced
this pull request
Feb 6, 2026
ethereum-optimism#19077) * fix: only allow enabling permissioned game types in opcmv2 deployment (#835) * fix: only allow permissioned game types in opcmv2 deployment * docs: add comment for permissionless games config in deployopchain * feat: add isInitialDeployment argument to std validator script * fix: undo OPCMv1 changes * fix: old test content * fix: expect validator errors for disabled games in deploy test CANNON and CANNON_KONA are intentionally disabled during initial deployment, so no implementations are registered. The validator correctly flags this as PLDG-10 and CKDG-10 errors. Update test to expect these errors. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: revert on non-PERMISSIONED_CANNON game type in DeployOPChain Address review feedback: raise an error instead of silently overwriting the disputeGameType input. Only PERMISSIONED_CANNON is valid for initial deployment since no prestate exists for permissionless games. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: niha <205694301+0xniha@users.noreply.github.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes OPT-1423