fix: set pdg implementations to non-zero address on v2 codepath#806
Merged
0xiamflux merged 2 commits intosc-feat/opcm2-refactor-zero-address-pdgfrom Jan 21, 2026
Merged
Conversation
…ss on v2 codepath
0xiamflux
commented
Jan 21, 2026
| // We first find the respected game type, if it's a fault game we can set the faultDisputeGame to the respected | ||
| // game implementation, otherwise we set it to address(0). | ||
| // This is to account for scenarios where both fault games are enabled. | ||
| GameType respectedGameType = _chainContracts.anchorStateRegistry.respectedGameType(); |
Author
There was a problem hiding this comment.
Per our discussion, decided to remove this and leave the faultDisputeGame in the output as address(0) which is consistent to how the OPCM v1 behaves.
0xniha
approved these changes
Jan 21, 2026
0xiamflux
merged commit 15576a5
into
sc-feat/opcm2-refactor-zero-address-pdg
1 check passed
0xiamflux
changed the title
0xOneTony
pushed a commit
that referenced
this pull request
Jan 23, 2026
…-optimism#18900) * fix: set fdg and pdg implementations to non-zero address on v2 codepath (#806) * fix: set fault and permission games implementations to non-zero address on v2 codepath * chore: make faultDisputeGame 0 on DeployOPChain * chore: remove unused import, just pr passing (#809)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets the Permission Dispute Game for OPCM v2 code path, sets the appropriate fault dispute game based on the respected game type selected when deploying the OP Chain. Also sets both the permissioned and permissionless delayed WETH impl to the same address as v2 code path deploys a single contract.
Closes OPT-1411