Skip to content

chore: improve comments accuracy #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0xDiscotech merged 1 commit into from
Dec 16, 2025
Merged

chore: improve comments accuracy #741

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/contracts-bedrock/src/L2/L1Withdrawer.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ contract L1Withdrawer is ISemver {
/// @param _minWithdrawalAmount The minimum amount of ETH required to trigger a withdrawal.
/// @param _recipient The L1 address that will receive withdrawals.
/// @param _withdrawalGasLimit The gas limit for the L1 withdrawal transaction.
/// @dev If target on L1 is `FeesDepositor`, the gas limit should be above 800k gas.
/// @dev If target on L1 is `FeesDepositor`, the gas limit should be at or above 800k gas.
constructor(uint256 _minWithdrawalAmount, address _recipient, uint32 _withdrawalGasLimit) {
minWithdrawalAmount = _minWithdrawalAmount;
recipient = _recipient;
Expand Down Expand Up @@ -105,7 +105,7 @@ contract L1Withdrawer is ISemver {

/// @notice Updates the withdrawal gas limit. Only callable by the ProxyAdmin owner.
/// @param _newWithdrawalGasLimit The new withdrawal gas limit.
/// @dev If target on L1 is `FeesDepositor`, the gas limit should be above 800k gas.
/// @dev If target on L1 is `FeesDepositor`, the gas limit should be at or above 800k gas.
function setWithdrawalGasLimit(uint32 _newWithdrawalGasLimit) external {
if (msg.sender != IProxyAdmin(Predeploys.PROXY_ADMIN).owner()) {
revert L1Withdrawer_OnlyProxyAdminOwner();
Expand Down