Skip to content

chore: improve comments accuracy#741

Merged
0xDiscotech merged 1 commit intosc-feat/improve-commentsfrom
chore/revshare-comments
Dec 16, 2025
Merged

chore: improve comments accuracy#741
0xDiscotech merged 1 commit intosc-feat/improve-commentsfrom
chore/revshare-comments

Conversation

@0xChin
Copy link
Copy Markdown
Member

@0xChin 0xChin commented Dec 9, 2025

Small PR improving the accuracy of the comments related to the gas required for the FeesDepositor. Here is a Gist with the traces of the gas costs when FeesDepositor receives ETH and triggers/doesn't trigger a portal deposit: https://gist.github.com/0xChin/f0e05c23599b9966f5601d27f71f5aae


Note

Clarifies L1Withdrawer.sol docs to state the L1 gas limit for FeesDepositor must be at or above 800k gas (constructor and setter comments).

Written by Cursor Bugbot for commit 974b442. This will update automatically on new commits. Configure here.

@0xChin 0xChin requested a review from 0xDiscotech December 9, 2025 15:57
@0xChin 0xChin self-assigned this Dec 9, 2025
@0xDiscotech 0xDiscotech merged commit 570b7fe into sc-feat/improve-comments Dec 16, 2025
2 checks passed
@0xDiscotech 0xDiscotech deleted the chore/revshare-comments branch December 16, 2025 20:57
0xiamflux pushed a commit that referenced this pull request Dec 18, 2025
* chore: improve comments accuracy (#741)

* fix: semver (#772)

---------

Co-authored-by: Chiin <77933451+0xChin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants