chore: improve comments accuracy#741
Merged
0xDiscotech merged 1 commit intosc-feat/improve-commentsfrom Dec 16, 2025
Merged
Conversation
0xDiscotech
approved these changes
Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small PR improving the accuracy of the comments related to the gas required for the FeesDepositor. Here is a Gist with the traces of the gas costs when FeesDepositor receives ETH and triggers/doesn't trigger a portal deposit: https://gist.github.com/0xChin/f0e05c23599b9966f5601d27f71f5aae
Note
Clarifies
L1Withdrawer.soldocs to state the L1 gas limit forFeesDepositormust be at or above 800k gas (constructor and setter comments).Written by Cursor Bugbot for commit 974b442. This will update automatically on new commits. Configure here.