fix: go linter

[agusduha]

Note

Refactors custom gas token config to be enabled by presence of name/symbol, adds LiquidityControllerOwner throughout, and updates deploy APIs and tests accordingly.

• Custom Gas Token config:
  • Enablement inferred via CustomGasToken.Name and Symbol; remove explicit Enabled flag and boolean params.
  • Add CustomGasToken.LiquidityControllerOwner with default to Roles.L2ProxyAdminOwner via GetLiquidityControllerOwner.
  • GetInitialLiquidity defaults to uint248.max when enabled and unspecified.
  • Validation in ChainIntent.Check updated for CGT fields.
• APIs updated:
  • sysgo.WithCustomGasToken and intentbuilder.L2Configurator.WithCustomGasToken signatures changed to (name, symbol, initialLiquidity, liquidityControllerOwner).
  • genesis.GasTokenDeployConfig now populated with LiquidityControllerOwner and inferred enablement.
  • Interop L2 genesis (interopgen.GenesisL2) accepts and forwards LiquidityControllerOwner.
• Tests and configs:
  • Update e2e/acceptance tests and defaults to new CGT model and method signatures.
  • Minor formatting/expectation tweaks in related tests.

^{Written by Cursor Bugbot for commit 0dfd566. This will update automatically on new commits. Configure here.}

[cursor]

This is the final PR Bugbot will review for you during this billing cycle

Your free Bugbot reviews will reset on November 16

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Bug: Custom Gas Token Cannot Be Disabled

The WithCustomGasToken method accepts an enabled parameter but completely ignores it. When enabled is false, callers expect the custom gas token to be disabled regardless of other parameters, but the function unconditionally sets Name, Symbol, and InitialLiquidity. This causes custom gas tokens to be enabled when enabled=false is passed with non-empty name/symbol values, violating the function's contract.

op-e2e/e2eutils/intentbuilder/builder.go#L472-L478

optimism/op-e2e/e2eutils/intentbuilder/builder.go

Lines 472 to 478 in 1bc5db9

	func (c *l2Configurator) WithCustomGasToken(enabled bool, name, symbol string, initialLiquidity *big.Int) {
	c.builder.intent.Chains[c.chainIndex].CustomGasToken = state.CustomGasToken{
	Name: name,
	Symbol: symbol,
	InitialLiquidity: (*hexutil.Big)(initialLiquidity),
	}

 

---