feat: add ownable liquidity

[ashitakah]

CLOSES OPT-1297
CLOSES OPT-1286
CLOSES OPT-1316

https://cantina.xyz/code/940ca124-08fb-4789-8dc4-5c677d3997f2/findings?finding=10

---

Note

Introduce Ownable LiquidityController with configurable owner, refactor custom gas token enablement/defaults, and wire through deploy/genesis, ABI, and tests.

• Contracts (L2):
  • LiquidityController now OwnableUpgradeable; initialize takes _owner; authorize/deauthorize gated by onlyOwner.
  • Update ILiquidityController interface/ABI and storage layout; add ownership events/functions.
  • Bump OPContractsManager version to 5.6.1.
• Genesis/Deploy Scripts:
  • L2Genesis.Input adds liquidityControllerOwner; initialize controller with owner; assert owner in tests.
  • Deploy config reads liquidityControllerOwner (default finalSystemOwner).
• Deployer (Go):
  • Refactor CGT: remove boolean flag in intent; CGT enabled when both name and symbol set.
  • Defaults: if CGT enabled and no initialLiquidity, use type(uint248).max; provide GetLiquidityControllerOwner() (defaults to L2ProxyAdminOwner).
  • Pass CGT config (incl. liquidityControllerOwner) to L2 genesis; validate non-zero owner in GasTokenDeployConfig.
• Tests:
  • Update unit/integration tests for new ownership semantics, CGT defaults/enablement, and config plumbing.
  • Snapshot updates for ABI/semver/storage.

^{Written by Cursor Bugbot for commit 8d0c373. This will update automatically on new commits. Configure here.}

[linear]

OPT-1297 Add Liquidity Controller owner

[cursor]

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

[linear]

OPT-1286 Enhance CGT deployment

[linear]

OPT-1316 CGT override bypasses intent validation #10

[cursor]

Bug: Liquidity Default Blocks Max Value.

The default value for NativeAssetLiquidityAmount in defaultOverrides() is set to a non-nil pointer to zero ((*hexutil.Big)(big.NewInt(0))). When custom gas token is enabled via overrides without explicitly specifying liquidity amount, this zero pointer gets assigned to the intent, causing GetInitialLiquidity() to return 0 instead of the intended default of type(uint248).max. The default should be nil to trigger the type(uint248).max fallback in GetInitialLiquidity() when CGT is enabled.

op-deployer/pkg/deployer/pipeline/l2genesis.go#L209-L210

optimism/op-deployer/pkg/deployer/pipeline/l2genesis.go

Lines 209 to 210 in 18ae9d8

	OperatorFeeVaultWithdrawalNetwork: "local",
	EnableGovernance: false,

 

---

[cursor]

Bug: Configuration Overrides Silently Ignored

The l2GenesisOverrides struct is missing a LiquidityControllerOwner field. When users provide liquidityControllerOwner in GlobalDeployOverrides (as shown in test case at l2genesis_test.go:235), the JSON merge in calculateL2GenesisOverrides silently ignores it since the field doesn't exist. This forces LiquidityControllerOwner to always default to L2ProxyAdminOwner when using overrides, even when users explicitly specify a different owner, creating an unexpected configuration gap.

op-deployer/pkg/deployer/pipeline/l2genesis.go#L23-L42

optimism/op-deployer/pkg/deployer/pipeline/l2genesis.go

Lines 23 to 42 in ba94130

	type l2GenesisOverrides struct {
	// ===== CUSTOM GAS TOKEN (CGT) CONFIGURATION =====
	UseCustomGasToken bool `json:"useCustomGasToken"` // CGT: Enable custom gas token mode
	GasPayingTokenName string `json:"gasPayingTokenName"` // CGT: Name of the custom gas token
	GasPayingTokenSymbol string `json:"gasPayingTokenSymbol"` // CGT: Symbol of the custom gas token
	NativeAssetLiquidityAmount *hexutil.Big `json:"nativeAssetLiquidityAmount"` // CGT: Liquidity amount for NativeAssetLiquidity contract
	// ===== GENERAL L2 CONFIGURATION (NON-CGT) =====
	FundDevAccounts bool `json:"fundDevAccounts"`
	BaseFeeVaultMinimumWithdrawalAmount *hexutil.Big `json:"baseFeeVaultMinimumWithdrawalAmount"`
	L1FeeVaultMinimumWithdrawalAmount *hexutil.Big `json:"l1FeeVaultMinimumWithdrawalAmount"`
	SequencerFeeVaultMinimumWithdrawalAmount *hexutil.Big `json:"sequencerFeeVaultMinimumWithdrawalAmount"`
	OperatorFeeVaultMinimumWithdrawalAmount *hexutil.Big `json:"operatorFeeVaultMinimumWithdrawalAmount"`
	BaseFeeVaultWithdrawalNetwork genesis.WithdrawalNetwork `json:"baseFeeVaultWithdrawalNetwork"`
	L1FeeVaultWithdrawalNetwork genesis.WithdrawalNetwork `json:"l1FeeVaultWithdrawalNetwork"`
	SequencerFeeVaultWithdrawalNetwork genesis.WithdrawalNetwork `json:"sequencerFeeVaultWithdrawalNetwork"`
	OperatorFeeVaultWithdrawalNetwork genesis.WithdrawalNetwork `json:"operatorFeeVaultWithdrawalNetwork"`
	EnableGovernance bool `json:"enableGovernance"`
	GovernanceTokenOwner common.Address `json:"governanceTokenOwner"`

 

---

[0xniha]

LGodTM!