feat: descope dependency manager

[agusduha]

No description provided.

[hexshire]

Why +1 ?

[agusduha]

It was that or fuzzing another chainId

[hexshire]

why uint8 here and uint128 in the test_addDependency_portalAlreadyAuthorized_reverts test.

[0xDiscotech]

this, it could be fuzzed using type(uint256).max I think

[0xDiscotech]

If removing the vm.skip() on DependencyManager tests, they fail with
[FAIL: revert: Proxy: implementation not initialized.
Is this expected or out of scope? Or should we ensure the contract is properly tested and covered even though it won't be part of the first version of the system?

[0xDiscotech]

If 0, loops and assertions will never be reached

Suggested change

	_chainIds = new uint256[](bound(_chainIds.length, 0, 32));
	_chainIds = new uint256[](bound(_chainIds.length, 1, 32));

[0xDiscotech]

This won't work. The fuzzed array is being overwritten by an empty array of the bounded length - so all the values will be 0.
If you want to fuzz the values on the array, but limit its size, you need to fuzz one and create another one, then copy its values:

    function testFuzz_dependencySet_succeeds(uint256[32] memory _chainIdsValues) public {
          // Limit array size to prevent too many rejections
          uint256[] memory chainIds = new uint256[](bound(_chainIdsValues.length, 1, 32));
  
          // Loop over the values and add them to the array
          for (uint256 i = 0; i < chainIds.length; i++) {
              chainIds[i] = _chainIdsValues[i];
    }

[0xDiscotech]

The same can be applied on the other 2 tests where this behavior is repeated

[0xDiscotech]

Approved since there will be one task to revisit the DependencyManager test once is included in the next release scope and vm.skip() is removed.