feat: integrate portal to lockbox

[agusduha]

• Integrate OptimismPortal to work with the SharedLockbox by locking and unlocking ETH.
• Add the SharedLockbox to the current scripts to be fully integrated for testing and deployments.
• Refactor OptimismPortal2 to be under the contract limit size.

Closes OPT-500
Closes OPT-557

[linear]

OPT-500 Integrate `OptimismPortal` with `SharedLockbox`

OPT-557 Modify `Deploy` script and `OPCM` to include `SharedLockbox`

[0xDiscotech]

Tests

Github didn't let me comment on untouched code, but here, we need to replace this https://github.dev/defi-wonderland/optimism/blob/141c2e18dbf565ac0b310c7346a9096ae9059447/packages/contracts-bedrock/test/L1/OptimismPortal2.t.sol#L881-L883
with

        vm.deal(address(sharedLockbox), _defaultTx_noData.value); 
        vm.expectCall(address(sharedLockbox), abi.encodeCall(sharedLockbox.unlockETH, (_defaultTx_noData.value)));

The same expectCall over the lockbox unlock() can be added on

• test_finalizeWithdrawalTransaction_provenWithdrawalHashEther_succeeds
• test_finalizeWithdrawalTransaction_secondaryProof_succeeds

And finally, it could be added on the rest of these tests (but I'm less sure):

• test_finalizeWithdrawalTransaction_targetFails_fails
• test_finalizeWithdrawalTransaction_onReplay_reverts
• test_finalizeWithdrawalTransaction_onReentrancy_reverts (on the first call)
  The reason why I think that it should be added even on tests that check a failure, is that they still check the events emitted on them, so IMO we should repeat the behavior with the expected call.

[0xDiscotech]

Missing assertEq(address(sharedLockbox).balance, 0); at the beggining of the test as well

[0xDiscotech]

The same check can be added at the beggining on _preBridgeETH and _preBridgeETHTo to maintain consistency as well.

Maybe we can even remove the assertEq(address(optimismPortal).balance, 0); check on them since it makes no sense now to check that. But if in doubt, we can keep it bc it doesn't harm

[agusduha]

I will add the check at the beginning, but for now will leave the portal one also

[0xDiscotech]

Perfect

[0xDiscotech]

The assertEq(address(sharedLockbox).balance, 0); check is missing on _preBridgeETHTo and _preBridgeETH

[0xParti]

This is amazing. Very clean code and tests!

[0xDiscotech]

Amazing job 👏