-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add finalizer for UDS Package CRs #953
Conversation
Going to try to figure out exactly why but FYI it seems like if I Create and then Delete many (5 or 6) packages at once the authservice secret does not get cleaned up properly. I see lingering chains for Packages that no longer exist. I checked back on |
I was able to reproduce the same issue identified ^, digging into it. |
Discussed offline with Micah but wanted to follow up here. Part of this change included moving from This was causing resource contention for the in memory copy of the authservice configuration in circumstances where many packages are deleted simultaneously due to the fact that the underlying Pepr store implementation would resolve the removeItemAndWait calls for every package at the same time. I introduced a basic resource lock to avoid the contention on the in the memory update. |
🤖 I have created a release *beep* *boop* --- ## [0.30.0](v0.29.1...v0.30.0) (2024-10-28) ### ⚠ BREAKING CHANGES * remove uds-runtime from core ([#955](#955)) ### Features * add finalizer for UDS Package CRs ([#953](#953)) ([fa42714](fa42714)) * adds registry1 flavor of uds runtime ([#925](#925)) ([0011852](0011852)) ### Bug Fixes * batch authservice checksum updates ([#735](#735)) ([100d35b](100d35b)) * logout redirect uri ([#945](#945)) ([8e2b5d8](8e2b5d8)) * resolve lingering note formatting ([#938](#938)) ([455a530](455a530)) * vector remap language logic typo ([#959](#959)) ([89af729](89af729)) ### Miscellaneous * add proper version update to aks nightly bundle ([#942](#942)) ([2f51c75](2f51c75)) * block local auth for neuvector ([#965](#965)) ([8f25b41](8f25b41)) * **deps:** update vector to 0.42.0 ([#946](#946)) ([2f63db2](2f63db2)) * remove uds-runtime from core ([#955](#955)) ([c6f6664](c6f6664)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Description
This PR moves our
onDelete
code into a finalizer, using Pepr'sFinalize
functionality. Due to an open Pepr feature request this does not update the Package CR status during deletion to avoid triggering the finalization multiple times. In order to provide visibility into deletion status and failure this adds eventing around the specific cleanup operations as well as specific failure events in catch blocks.This PR does also add a new status to the Package CR of
Removing
, which was stubbed out for a future state where we may be able to use it (pending addition of the Pepr feature to not delete the finalizer).3 additional related QoL changes:
addlicense
is run on generated CRD files post-generateRelated Issue
Fixes #523
Type of change
Checklist before merging