Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve lingering note formatting #938

Merged
merged 2 commits into from
Oct 21, 2024
Merged

fix: resolve lingering note formatting #938

merged 2 commits into from
Oct 21, 2024

Conversation

pauldipietro
Copy link
Contributor

Description

The old note format was used in a couple places and required updating.

Related Issue

N/A

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@pauldipietro pauldipietro added the documentation Improvements or additions to documentation label Oct 18, 2024
@pauldipietro pauldipietro requested a review from a team as a code owner October 18, 2024 16:44
@UnicornChance
Copy link
Contributor

@pauldipietro you'll need to fix the title of the PR for the Metadata / Validate PR Title ci job to pass. just needs to be formatted a bit differently: Fix -> fix:. We try to stick to conventional commits so that the release notes are easily read/maintained. As soon as that's resolved we can approve and get this merged!

@pauldipietro pauldipietro changed the title Fix lingering note formatting fix: resolve lingering note formatting Oct 21, 2024
@UnicornChance UnicornChance merged commit 455a530 into main Oct 21, 2024
10 checks passed
@UnicornChance UnicornChance deleted the fix-notes branch October 21, 2024 13:52
rjferguson21 pushed a commit that referenced this pull request Oct 28, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.30.0](v0.29.1...v0.30.0)
(2024-10-28)


### ⚠ BREAKING CHANGES

* remove uds-runtime from core
([#955](#955))

### Features

* add finalizer for UDS Package CRs
([#953](#953))
([fa42714](fa42714))
* adds registry1 flavor of uds runtime
([#925](#925))
([0011852](0011852))


### Bug Fixes

* batch authservice checksum updates
([#735](#735))
([100d35b](100d35b))
* logout redirect uri
([#945](#945))
([8e2b5d8](8e2b5d8))
* resolve lingering note formatting
([#938](#938))
([455a530](455a530))
* vector remap language logic typo
([#959](#959))
([89af729](89af729))


### Miscellaneous

* add proper version update to aks nightly bundle
([#942](#942))
([2f51c75](2f51c75))
* block local auth for neuvector
([#965](#965))
([8f25b41](8f25b41))
* **deps:** update vector to 0.42.0
([#946](#946))
([2f63db2](2f63db2))
* remove uds-runtime from core
([#955](#955))
([c6f6664](c6f6664))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants