fix: istio proxy exiting early when Pod has restart policy #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjnagel
approved these changes
Oct 16, 2024
docandrew
pushed a commit
that referenced
this pull request
Oct 17, 2024
## Description This changes the proxy cleanup logic to be: All containers terminated AND either: - restartPolicy of Never - restartPolicy of OnFailure w/0 exit code A restartPolicy of Always should keep restarting the containers inside the pod and should not need proxy cleanup. ## Related Issue Fixes #913 ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [ ] Test, docs, adr added or updated as needed - [x] [Contributor Guide](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md) followed
mjnagel
pushed a commit
that referenced
this pull request
Oct 18, 2024
🤖 I have created a release *beep* *boop* --- ## [0.29.1](v0.29.0...v0.29.1) (2024-10-18) ### Bug Fixes * adr link in func layers doc ([#903](#903)) ([c42ccf8](c42ccf8)) * codespell config ([#934](#934)) ([73eb385](73eb385)) * decompose istio oscal ([#826](#826)) ([83c6ae5](83c6ae5)) * don't add duplicate policy names to `uds-core.pepr.dev/mutated` annotation ([#916](#916)) ([99d1c83](99d1c83)) * istio proxy exiting early when Pod has restart policy ([#914](#914)) ([f87e3d4](f87e3d4)) * release-please for aks ([#941](#941)) ([5c77285](5c77285)) * test ci license check ([#924](#924)) ([c5b1d54](c5b1d54)) ### Miscellaneous * add e2e playwright tests for grafana ([#844](#844)) ([1af5a8f](1af5a8f)) * add local lula compose task ([#892](#892)) ([075b519](075b519)) * add nightly testing for AKS ([#908](#908)) ([105aea6](105aea6)) * add playwright deps to support-deps renovate ([#937](#937)) ([94655cd](94655cd)) * **deps:** revert pepr to 0.37.2 ([#940](#940)) ([3317bbe](3317bbe)) * **deps:** update grafana helm chart to v8.5.5 ([#905](#905)) ([ca9a485](ca9a485)) * **deps:** update pepr to v0.38.0 ([#870](#870)) ([de8419c](de8419c)) * **deps:** update pepr to v0.38.0 ([#915](#915)) ([6fe4e57](6fe4e57)) * **deps:** update pepr to v0.38.1 ([#922](#922)) ([3c5d341](3c5d341)) * **deps:** update prometheus-stack ([#863](#863)) ([d3f03b4](d3f03b4)) * **deps:** update prometheus-stack to v65.3.1 ([#920](#920)) ([0b80107](0b80107)) * **deps:** update runtime to v0.6.1 ([#910](#910)) ([be63105](be63105)) * **deps:** update support dependencies to v0.192.0 ([#906](#906)) ([8dfd362](8dfd362)) * **deps:** update support-deps ([#898](#898)) ([380af83](380af83)) * **deps:** update support-deps ([#912](#912)) ([bf23a89](bf23a89)) * **docs:** custom resource docs generation ([#902](#902)) ([e73597d](e73597d)) * ensure http2 watch config is used by internal exemption watch ([#909](#909)) ([25bfd59](25bfd59)) * group setup action in support deps ([#930](#930)) ([d0a0123](d0a0123)) * group vscode/settings.json with support-deps ([#933](#933)) ([81e41d8](81e41d8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes the proxy cleanup logic to be:
All containers terminated AND either:
A restartPolicy of Always should keep restarting the containers inside the pod and should not need proxy cleanup.
Related Issue
Fixes #913
Type of change
Checklist before merging