Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Istio Proxy sidecar being completed too early in Jobs with containers with restartPolicies #913

Closed
Racer159 opened this issue Oct 15, 2024 · 0 comments · Fixed by #914
Closed

Istio Proxy sidecar being completed too early in Jobs with containers with restartPolicies #913

Racer159 opened this issue Oct 15, 2024 · 0 comments · Fixed by #914
Labels
bug Something isn't working

Comments

@Racer159
Copy link
Contributor

Environment

Device and OS: Framework 16
App version: 0.28.0+
Kubernetes distro being used: k3d
Other: uds-cli 0.17.0

Steps to reproduce

  1. Deploy a UDS Package (like GitLab) that has a Job that is expected to fail and restart (restartPolicy: OnFailure)

Expected result

Package deploys successfully

Actual Result

Package deployment fails because the sidecar is killed after the first failure in the container

Visual Proof (screenshots, videos, text, etc)

image

Severity/Priority

Medium-High - this will mean some packages are not deployable on UDS Core until this is fixed.

Additional Context

Related to this change: #813
@Racer159 Racer159 added possible-bug Something may not be working bug Something isn't working and removed possible-bug Something may not be working labels Oct 15, 2024
@Racer159 Racer159 mentioned this issue Oct 15, 2024
Merged
5 tasks
mjnagel pushed a commit that referenced this issue Oct 16, 2024
@Racer159
fix: istio proxy exiting early when Pod has restart policy (#914)
f87e3d4 
## Description

This changes the proxy cleanup logic to be:

All containers terminated AND either:
- restartPolicy of Never
- restartPolicy of OnFailure w/0 exit code

A restartPolicy of Always should keep restarting the containers inside
the pod and should not need proxy cleanup.

## Related Issue

Fixes #913 

## Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [ ] Test, docs, adr added or updated as needed
- [x] [Contributor
Guide](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)
followed
docandrew pushed a commit that referenced this issue Oct 17, 2024
@Racer159 @docandrew
fix: istio proxy exiting early when Pod has restart policy (#914)
ef5e2d8 
## Description

This changes the proxy cleanup logic to be:

All containers terminated AND either:
- restartPolicy of Never
- restartPolicy of OnFailure w/0 exit code

A restartPolicy of Always should keep restarting the containers inside
the pod and should not need proxy cleanup.

## Related Issue

Fixes #913 

## Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [ ] Test, docs, adr added or updated as needed
- [x] [Contributor
Guide](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)
followed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: istio proxy exiting early when Pod has restart policy defenseunicorns/uds-core
1 participant
@Racer159