Skip to content

Propagate max errorcode to deepspeed when using PDSH launcher #1994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeffra merged 2 commits into from
Jun 7, 2022
Merged

Propagate max errorcode to deepspeed when using PDSH launcher #1994

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b281d6
Propagate max errorcode to deepspeed when using PDSH launcher
Jun 6, 2022
b78c929
Merge pull request #1 from microsoft/master
jerrymannil Jun 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deepspeed/launcher/multinode_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def get_cmd(self, environment, active_resources):

# PDSH flags for max node fan out and specific hosts to launch on
# See https://linux.die.net/man/1/pdsh for flag details
pdsh_cmd_args = ['pdsh', '-f', str(PDSH_MAX_FAN_OUT), '-w', active_workers]
pdsh_cmd_args = ['pdsh', '-S', '-f', str(PDSH_MAX_FAN_OUT), '-w', active_workers]

exports = ""
for key, val in self.exports.items():
Expand Down