Propagate max errorcode to deepspeed when using PDSH launcher #1994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add '-S' argument to pdsh command to return the largest error code from the ssh sessions
jerrymannil
requested review from
RezaYazdaniAminabadi,
ShadenSmith,
awan-10,
cli99,
conglongli,
eltonzheng,
jeffra,
minjiaz,
samyam and
tjruwase
as code owners
jeffra
approved these changes
Jun 6, 2022
Collaborator
jeffra
left a comment
jeffra
left a comment
There was a problem hiding this comment.
Thank you @jerrymannil, this is great.
Collaborator
|
@jerrymannil for some reason it won't let me update your branch align it with latest commits in |
Merge master branch
Contributor
Author
|
@jeffra Merged with the master branch now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add '-S' argument to pdsh command to return the largest error code from the ssh sessions