chore: Upgrade and pin transformers to 4.21.2 #3098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vblagoje
changed the title
julian-risch
approved these changes
Aug 29, 2022
Member
julian-risch
left a comment
julian-risch
left a comment
There was a problem hiding this comment.
Looks good to me! 👍 I am very much looking forward to this as should be anybody using M1 or M2. 🙂 I had a brief look through transformers release notes but didn't see anything that could cause trouble: https://github.com/huggingface/transformers/releases
There were some bugs in 4.21.0 but they have been fixed in the two patch releases since then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades and pins transformers to 4.21.2
The most important change for us allowing "mps" devices in pipelines
After upgrading and pinning to 4.21.2, we can complete #3062
How did you test it?
We'll check whether any tests fail, for example, due to deprecated/discontinued features or breaking changes. We'll also comb through the changelog and check for any changes that might affect Haystack.