dcrdtest: Use dcrd IPC to obtain subsys addrs #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusd
force-pushed
the
dcrd-ipc
branch
6 times, most recently
from
9ce3e22 to
d3e3216
Compare
matheusd
force-pushed
the
dcrd-ipc
branch
2 times, most recently
from
d7dfe84 to
b0545a5
Compare
This modifies the harness code to bind dcrd's subsystems (P2P and RPC) to random ports, while using the IPC subsystem and the recently introduced --boundaddrevents argument to obtain the OS-assigned ports. This improves the reliability of the package by ensuring the harnesses don't attempt to bind to a port that may already be in use, causing flaky test failures that are hard to diagnose and reproduce.
This provides a cleaner shutdown procedure in windows, where the interrupt signal is not available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #6(merged)Requires decred/dcrd#3020(merged)Closes #4
This modifies the harness code to bind dcrd's subsystems (P2P and
RPC) to random ports, while using the IPC subsystem and the recently
introduced --boundaddrevents argument to obtain the OS-assigned ports.
This improves the reliability of the package by ensuring the harnesses
don't attempt to bind to a port that may already be in use, causing
flaky test failures that are hard to diagnose and reproduce.