server: Add bound addresses IPC events #3020
Conversation
|
It's not clear to me what the semantics are for the protocol version (whether it's only meant to guard the encoding or the actual contents/types of messages). Based on this comment in the original implementation I was under the impression it would only be used for encoding, so that's why I didn't bump it. I'm ok with switching to using the IPC protocol version as a discriminant for what sorts of messages are emitted. If we do so, I'll improve the documentation a little bit to make it more explicit what the version refers to. |
After discussing this a bit with the original author, the protocol version there was only intended to refer to the encoding. Since adding new message types doesn't affect that and can safely be ignored, it doesn't need to be bumped. Depending on how the spawning processes handle it, bumping it could potentially break them. That said, it does seem to me like giving the spawning process a way to determine which messages are available would be ideal, because it could otherwise spawn a slightly older version of dcrd (say the commit just prior to this one) and it wouldn't be available. I realize that because this PR is introducing a CLI flag, attempting to launch that slightly older version of dcrd would fail due to an unknown flag, so it doesn't really apply in this case, but my guy tells me that, in the more general case, not gating behind a flag and instead allowing the spawning process to discover whether or not a specific capability is available would result in a nicer UX. That would not be something for this PR however. |
Looks like we were both making a comment at the same time, but yes, I've confirmed with the original author that is the intent.
I discussed that a bit in my comment above that I was typing while you made this comment too. We can follow up on that separate since it's not something for this PR regardless. |
This adds a new set of IPC events sent over the TX pipe that report the locally bound addresses of the P2P and RPC interfaces. The main goal for this feature is to enable binding dcrd to a random port (using for example, --listen :0) while enabling a controlling parent process to learn the address that was assigned to dcrd by the OS. The events are only sent when the --boundaddrevents flag is specified.
matheusd
force-pushed
the
random-bind-port
branch
from
9f5cf62 to
6e1eb79
Compare
This adds a new set of IPC events sent over the TX pipe that report the locally bound addresses of the P2P and RPC interfaces.
The main goal for this feature is to enable binding dcrd to a random port (using for example, --listen :0) while enabling a controlling parent process to learn the address that was assigned to dcrd by the OS.
The events are only sent when the --boundaddrevents flag is specified.
Closes #3018