mempool: Accept test mungers for create signed tx. #1576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
mempool_accept_mungers_oncstx
branch
from
dfd71b1 to
df84fbd
Compare
dnldd
approved these changes
Jan 26, 2019
matheusd
approved these changes
Jan 28, 2019
jrick
approved these changes
Jan 28, 2019
This modifies CreateSignedTx in the mempool test harness to accept munge functions similar to how NextBlock in chaingen works and updates the callers accordingly. This allows the test code to more easily mutate the transactions as desired prior to them being signed which provides greater flexibility. While here, it also sets the input amount to the proper value in the generated transaction. While there is not currently anything in the tests that relies on that value being accurate, it is more desirable to create transactions in the test code which are fully valid in case they end up being used where it does matter in future tests.
davecgh
force-pushed
the
mempool_accept_mungers_oncstx
branch
from
df84fbd to
385890d
Compare
alexlyp
approved these changes
Jan 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies
CreateSignedTxin themempooltest harness to accept munge functions similar to howNextBlockinchaingenworks and updates the callers accordingly. This allows the test code to more easily mutate the transactions as desired prior to them being signed which provides greater flexibility.While here, it also sets the input amount to the proper value in the generated transaction. While there is not currently anything in the tests that relies on that value being accurate, it is more desirable to create transactions in the test code which are fully valid in case they end up being used where it does matter in future tests.