mempool: Implement test harness seq lock calc. #1577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
mempool_test_implement_calcseqlock
branch
from
3ba309b to
e36b0c9
Compare
dajohi
reviewed
Jan 27, 2019
dajohi
approved these changes
Jan 27, 2019
jrick
approved these changes
Jan 28, 2019
alexlyp
approved these changes
Jan 28, 2019
This adds infrastructure to the mempool test harness to allow the faked chain to handle sequence lock calculation for use in upcoming sequence lock tests. In particular, it modifies the existing CalcSequenceLock function on the faked chain to perform the full sequence lock calculation versus simply returning a lock that is always valid. Since by-time sequence lock calculation in CalcSequenceLock depends on the ability to calculate the median time for the block before the block that contains the input being spent and the test harness only provides an incomplete faked chain, this introduces a map which tracks the median times per utxo and provides two new functions named FakeUxtoMedianTime and AddFakeUtxoMedianTime which the tests can make use of to properly fake the necessary data to perform the calculations. Finally, since sequence locks require v2 transactions, the pool harness policy now allows a maximum transaction version of 2.
davecgh
force-pushed
the
mempool_test_implement_calcseqlock
branch
from
e36b0c9 to
51330a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds infrastructure to the
mempooltest harness to allow the faked chain to handle sequence lock calculation for use in upcoming sequence lock tests.In particular, it modifies the existing
CalcSequenceLockfunction on the faked chain to perform the full sequence lock calculation versus simply returning a lock that is always valid.Since by-time sequence lock calculation in
CalcSequenceLockdepends on the ability to calculate the median time for the block before the block that contains the input being spent and the test harness only provides an incomplete faked chain, this introduces a map which tracks the median times per utxo and provides two new functions namedFakeUxtoMedianTimeandAddFakeUtxoMedianTimewhich the tests can make use of to properly fake the necessary data to perform the calculations.Finally, since sequence locks require v2 transactions, the pool harness policy now allows a maximum transaction version of 2.