Skip to content
This repository was archived by the owner on Feb 6, 2024. It is now read-only.

studio: replace all platform icons with local icons #563

Closed
peterpeterparker opened this issue Jan 8, 2020 · 0 comments
Closed

studio: replace all platform icons with local icons #563

peterpeterparker opened this issue Jan 8, 2020 · 0 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers studio "Studio" is the codename for the web editor

Comments

@peterpeterparker
Copy link
Contributor

Affected part of DeckDeckGo

  • [X ] Studio

Reproduction

ion-icons are a acting a bit weirdly when it comes to conditional rendering and when a specific platform is used (like <ion-icon md="md-...." ios="md...."/>).

Instead of these, we should download the related svg icon from https://ionicons.com
Add these to our assets folder and then reference these as src (<ion-icon src='....'/>)

@peterpeterparker peterpeterparker added bug Something isn't working good first issue Good for newcomers studio "Studio" is the codename for the web editor labels Jan 8, 2020
@peterpeterparker peterpeterparker self-assigned this Jan 10, 2020
@peterpeterparker peterpeterparker added this to the studio-beta.11 milestone Jan 10, 2020
peterpeterparker added a commit that referenced this issue Jan 10, 2020
peterpeterparker added a commit that referenced this issue Jan 10, 2020
Signed-off-by: peterpeterparker <[email protected]>
peterpeterparker added a commit that referenced this issue Jan 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working good first issue Good for newcomers studio "Studio" is the codename for the web editor
Projects
None yet
Development

No branches or pull requests

1 participant