Skip to content
This repository was archived by the owner on Feb 6, 2024. It is now read-only.

Commit

Permalink
fix(#563): use local icons instead of platform specific
Browse files Browse the repository at this point in the history
Signed-off-by: peterpeterparker <[email protected]>
  • Loading branch information
peterpeterparker committed Jan 10, 2020
1 parent 64e23bb commit cc2367d
Show file tree
Hide file tree
Showing 11 changed files with 12 additions and 9 deletions.
2 changes: 1 addition & 1 deletion studio/src/app/components/core/app-avatar/app-avatar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export class AppAvatar {
</ion-avatar>
} else {
return <ion-avatar>
<ion-icon name="person" md="md-person" ios="md-person" aria-label={this.ariaLabel}></ion-icon>
<ion-icon src="/assets/icons/ionicons/md-person.svg" aria-label={this.ariaLabel}></ion-icon>
</ion-avatar>
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ export class AppEditorActions {

<ion-tab-button onClick={(e: UIEvent) => this.openMoreActions(e)} color="primary" class="small-devices"
mode="md">
<ion-icon name="more" md="md-more" ios="md-more"></ion-icon>
<ion-icon src="/assets/icons/ionicons/md-more.svg"></ion-icon>
<ion-label>More</ion-label>
</ion-tab-button>
</ion-buttons>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export class AppHelpAction {

render() {
return <ion-tab-button onClick={() => this.openGetHelp()} color="primary" mode="md" class="get-help-action">
<ion-icon name="help" md="md-help" ios="md-help"></ion-icon>
<ion-icon src="/assets/icons/ionicons/md-help.svg"></ion-icon>
<ion-label>Help</ion-label>
</ion-tab-button>
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ export class AppColorDeckSlide {
<deckgo-color class="ion-padding-start ion-padding-end ion-padding-bottom" more={this.moreColors}
onColorChange={($event: CustomEvent) => this.selectColor($event)}
color-rgb={this.color}>
<ion-icon name="more" ios="md-mode" md="md-more" slot="more" aria-label="More" class="more"></ion-icon>
<ion-icon src="/assets/icons/ionicons/md-more.svg" slot="more" aria-label="More" class="more"></ion-icon>
</deckgo-color>
]
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ export class AppColorCode {

<div class={this.codeColorType === undefined ? 'ion-padding-start disabled' : 'ion-padding-start'}>
<deckgo-color class="ion-padding-bottom" onColorChange={($event: CustomEvent) => this.selectColor($event, this.setCodeColor)} color-rgb={this.codeColor} more={this.moreColors}>
<ion-icon name="more" ios="md-mode" md="md-more" slot="more" aria-label="More" class="more"></ion-icon>
<ion-icon src="/assets/icons/ionicons/md-more.svg" slot="more" aria-label="More" class="more"></ion-icon>
</deckgo-color>
</div>

Expand Down Expand Up @@ -367,7 +367,7 @@ export class AppColorCode {

<div class={!this.highlightLines || this.highlightLines === undefined ? 'ion-padding-start disabled' : 'ion-padding-start'}>
<deckgo-color class="ion-padding-bottom" onColorChange={($event: CustomEvent) => this.selectColor($event, this.setHighlightColor)} color-rgb={this.highlightColor} more={this.moreColors}>
<ion-icon name="more" ios="md-mode" md="md-more" slot="more" aria-label="More" class="more"></ion-icon>
<ion-icon src="/assets/icons/ionicons/md-more.svg" slot="more" aria-label="More" class="more"></ion-icon>
</deckgo-color>
</div>
</ion-list>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ export class AppColorQRCode {
</ion-list>,
<deckgo-color class="ion-padding-start ion-padding-end ion-padding-bottom" more={this.moreColors}
onColorChange={($event: CustomEvent) => this.selectColor($event)} color-rgb={this.color}>
<ion-icon name="more" ios="md-mode" md="md-more" slot="more" aria-label="More" class="more"></ion-icon>
<ion-icon src="/assets/icons/ionicons/md-more.svg" slot="more" aria-label="More" class="more"></ion-icon>
</deckgo-color>,
<ion-item class="action-button ion-margin-bottom">
<ion-button shape="round" onClick={() => this.resetColor()}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ export class AppColorSides {
</ion-list>,
<deckgo-color class="ion-padding-start ion-padding-end ion-padding-bottom" more={this.moreColors}
onColorChange={($event: CustomEvent) => this.selectColor($event)} color-rgb={this.color}>
<ion-icon name="more" ios="md-mode" md="md-more" slot="more" aria-label="More" class="more"></ion-icon>
<ion-icon src="/assets/icons/ionicons/md-more.svg" slot="more" aria-label="More" class="more"></ion-icon>
</deckgo-color>,
<ion-item class="action-button ion-margin-bottom">
<ion-button shape="round" onClick={() => this.resetColor()}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ export class AppColorTextBackground {
</ion-list>,
<deckgo-color class="ion-padding-start ion-padding-end ion-padding-bottom" more={this.moreColors}
onColorChange={($event: CustomEvent) => this.selectColor($event)} color-rgb={this.color}>
<ion-icon name="more" ios="md-mode" md="md-more" slot="more" aria-label="More" class="more"></ion-icon>
<ion-icon src="/assets/icons/ionicons/md-more.svg" slot="more" aria-label="More" class="more"></ion-icon>
</deckgo-color>,
<ion-item class="action-button ion-margin-bottom">
<ion-button shape="round" onClick={() => this.resetColor()}
Expand Down
1 change: 1 addition & 0 deletions studio/src/assets/icons/ionicons/md-help.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions studio/src/assets/icons/ionicons/md-more.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions studio/src/assets/icons/ionicons/md-person.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit cc2367d

Please sign in to comment.