Skip to content

Use Tapioca for RBI generation#103

Merged
dduugg merged 10 commits intomainfrom
tapioca
Aug 23, 2022
Merged

Use Tapioca for RBI generation#103
dduugg merged 10 commits intomainfrom
tapioca

Conversation

@dduugg
Copy link
Copy Markdown
Owner

@dduugg dduugg commented Aug 6, 2022

No description provided.

@dduugg
Copy link
Copy Markdown
Owner Author

dduugg commented Aug 9, 2022

Closing pending a new tapioca release that incorporates Shopify/tapioca#1102

@dduugg dduugg closed this Aug 9, 2022
@dduugg
Copy link
Copy Markdown
Owner Author

dduugg commented Aug 22, 2022

Re-opening now that tapioca v0.9.4 resolves the missing methods issue

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 22, 2022

Codecov Report

Merging #103 (c1fecc1) into main (399bac0) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #103   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines          739       739           
=========================================
  Hits           739       739           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Copy Markdown
Contributor

@KaanOzkan KaanOzkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tapioca migration LGTM. Had to do some Gemfile.lock changes due to rebase conflicts.


BUNDLED WITH
2.3.20
2.3.13
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Downgraded the bundler version to keep platform specific versions of sorbet-static until a version with ruby/rubygems#5832 is released.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've kept this, but just fyi, when I run bundle update locally with bundler 2.3.13 i get this error: ruby/rubygems#5088

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. It's working for me on Ruby 3.1.2. Hopefully we can bump Bundler soon.

sorbet-static (= 0.5.10365)
sorbet-runtime (0.5.10365)
sorbet-static (0.5.10365-x86_64-linux)
sorbet (0.5.10346)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried for quite a bit but couldn't get sorbet to be bumped given the new Gemfile.lock. Nothing jumps out to me that is limiting Sorbet version 😕 Maybe you can have more luck locally.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's likely because there are no darwin builds for the new release due to https://sorbet-ruby.slack.com/archives/CHN2L03NH/p1660847337669779

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find, I was very confused.

@dduugg dduugg merged commit 9696734 into main Aug 23, 2022
@dduugg dduugg deleted the tapioca branch August 23, 2022 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants