Closed
Conversation
Contributor
|
I believe this is going to be fixed by Shopify/tapioca#1102. @dduugg can you confirm? Thanks! |
b8b1035 to
5974cd0
Compare
Contributor
Author
|
@Morriar should be! This benefits slightly from having a type signature, but that's low value. Closing for now, will re-open if the underlying issue isn't fixed in the next Tapioca release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Changes
Adds the
logmethod in an attempt to solve the problem posted here (and pasted below):I'm attempting to migrate
yard-sorbetto usetapiocafor RBI generation. WIP PR: dduugg/yard-sorbet#103I'm following the migration guide: https://github.com/Shopify/tapioca/wiki/Migrating-to-Tapioca
However, typechecking is currently failing:
logis defined byyardhere: https://github.com/lsegal/yard/blob/main/lib/yard/globals.rb#L20-L22My understanding is that I should be able to resolve this by adding requiring
yard/globalsintapioca/require, then invokingbin/tapioca gem yard, which I attempted to do in these commits:dduugg/yard-sorbet@9e00ecd
dduugg/yard-sorbet@8717134
However, I'm still seeing the same errors when I attempt to invoke
srb tcWhat am I doing wrong?