Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update window and grain_to_date to fix typo #3982

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Update window and grain_to_date to fix typo #3982

merged 1 commit into from
Aug 29, 2023

Conversation

runleonarun
Copy link
Collaborator

Fixes #3981

What are you changing in this pull request and why?

There seems to be a copy pasta typo 🍝

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Adding new pages (delete if not applicable):

  • Add page to website/sidebars.js
  • Provide a unique filename for the new page

Removing or renaming existing pages (delete if not applicable):

  • Remove page from website/sidebars.js
  • Add an entry website/static/_redirects
  • Ran link testing to update the links that point to the deleted page

@runleonarun runleonarun requested a review from a team as a code owner August 28, 2023 23:54
@netlify
Copy link

netlify bot commented Aug 28, 2023 •
edited
Loading

✅ Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit 7181389
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/64ed33cdb3a6160008373d2b
😎 Deploy Preview https://deploy-preview-3982--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: x-small This change will take under 3 hours to fix. and removed Docs team Authored by the Docs team @dbt Labs labels Aug 28, 2023
@runleonarun runleonarun mentioned this pull request Aug 28, 2023
Closed
1 task
@runleonarun runleonarun changed the title Update cumulative-metrics.md Update window and grain_to_date to fix typo Aug 28, 2023
Jstein77
Jstein77 approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@Jstein77 Jstein77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@runleonarun runleonarun merged commit ad40d25 into current Aug 29, 2023
12 checks passed
@runleonarun runleonarun deleted the runleonarun-patch-8 branch August 29, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jstein77 Jstein77 Jstein77 approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

window - can't be used with window
2 participants
@runleonarun @Jstein77