Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

window - can't be used with window #3981

Closed
1 task done
wanalytics8 opened this issue Aug 28, 2023 · 1 comment · Fixed by #3982
Closed
1 task done

window - can't be used with window #3981

wanalytics8 opened this issue Aug 28, 2023 · 1 comment · Fixed by #3982
Labels
engineering improvement that requires site engineering help or back up

Comments

@wanalytics8
Copy link

Contributions

  • I have read the contribution docs, and understand what's expected of me.

What page(s) or areas on docs.getdbt.com are affected?

https://docs.getdbt.com/docs/build/metrics-overview

What changes are you suggesting?

"The accumulation window, such as 1 month, 7 days, 1 year. This can't be used with window."

I think this is not correct, window can't be used with window? Or please explain, thanks!

Additional information

No response
@wanalytics8 wanalytics8 added the engineering improvement that requires site engineering help or back up label Aug 28, 2023
@runleonarun runleonarun mentioned this issue Aug 28, 2023
Merged
7 tasks
@runleonarun
Copy link
Collaborator

runleonarun commented Aug 28, 2023 •
edited
Loading

Thanks for catching this typo @wanalytics8 ! Fix proposed in #3982

runleonarun added a commit that referenced this issue Aug 29, 2023
@runleonarun
Update window and grain_to_date to fix typo (#3982)
ad40d25 
Fixes #3981

## What are you changing in this pull request and why?

There seems to be a copy pasta typo 🍝 


## Checklist
<!--
Uncomment if you're publishing docs for a prerelease version of dbt
(delete if not applicable):
- [ ] Add versioning components, as described in [Versioning
Docs](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#versioning-entire-pages)
- [ ] Add a note to the prerelease version [Migration
Guide](https://github.com/dbt-labs/docs.getdbt.com/tree/current/website/docs/guides/migration/versions)
-->
- [ ] Review the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md)
and [About
versioning](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#adding-a-new-version)
so my content adheres to these guidelines.
- [ ] Add a checklist item for anything that needs to happen before this
PR is merged, such as "needs technical review" or "change base branch."

Adding new pages (delete if not applicable):
- [ ] Add page to `website/sidebars.js`
- [ ] Provide a unique filename for the new page

Removing or renaming existing pages (delete if not applicable):
- [ ] Remove page from `website/sidebars.js`
- [ ] Add an entry `website/static/_redirects`
- [ ] [Ran link
testing](https://github.com/dbt-labs/docs.getdbt.com#running-the-cypress-tests-locally)
to update the links that point to the deleted page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
engineering improvement that requires site engineering help or back up
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update window and grain_to_date to fix typo dbt-labs/docs.getdbt.com
2 participants
@runleonarun @wanalytics8