Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/0.20.0 compatibility (rebased) #371

Merged
merged 5 commits into from
Jun 5, 2021
Merged

Feature/0.20.0 compatibility (rebased) #371

merged 5 commits into from
Jun 5, 2021

Conversation

clrcrl
Copy link
Contributor

@clrcrl clrcrl commented May 19, 2021 •
edited by jtcohen6
Loading

This is a:

  • bug fix PR with no breaking changes — please ensure the base branch is master
  • new functionality — please ensure the base branch is the latest dev/ branch
  • a breaking change — please ensure the base branch is the latest dev/ branch

To do

  • do we want to remove some of the "final CTEs" in the schema tests?
  • should we shim the unique_where test over to core?
  • should we remove any where args on other schema tests?

Description & motivation

Checklist

  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to CHANGELOG.md

@clrcrl clrcrl force-pushed the feature/0.20.0-compatibility-rebased branch from 8db0ff5 to a9c5551 Compare May 19, 2021 15:34
@jtcohen6 jtcohen6 force-pushed the feature/0.20.0-compatibility-rebased branch from 1bea581 to d2018fa Compare June 5, 2021 21:30
@jtcohen6 jtcohen6 force-pushed the feature/0.20.0-compatibility-rebased branch from d2018fa to da6e876 Compare June 5, 2021 21:47
@jtcohen6 jtcohen6 marked this pull request as ready for review June 5, 2021 22:03
@jtcohen6 jtcohen6 merged commit 28eb11d into dev/0.7.0 Jun 5, 2021
@jtcohen6 jtcohen6 deleted the feature/0.20.0-compatibility-rebased branch June 5, 2021 22:30
jtcohen6 added a commit that referenced this pull request Jun 6, 2021
@clrcrl @jtcohen6 @ChristopheDuong
0.7.0 into main (#372)
a729044 
* Tidy up changelog

* Add 0.7.0 entry to changelog

* Add order_by argument to get_column_values (#349)

* Add slugify macro to utils, use in pivot macro (#314)

* 0.20.0 compatibility (#371)

* Explicitly redefine Redshift -> default

* Upgrade generic tests

* Rm namespaces macro. New dispatch syntax

* Run tests with 0.20.0rc1

* Update changelog, readme

Co-authored-by: Jeremy Cohen <[email protected]>

* Simplify concat (#373)

* Postgres also have an alternative concat binary operation (#296)

* Update default implementation of concat macro

Co-authored-by: Christophe Duong <[email protected]>

Co-authored-by: Jeremy Cohen <[email protected]>
Co-authored-by: Christophe Duong <[email protected]>
jtcohen6 referenced this pull request Oct 8, 2021
@jtcohen6
Bump upper bound to <0.22 (#398)
696cf26 
* Bump upper bound to <0.22

* Add changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtcohen6 jtcohen6 jtcohen6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clrcrl @jtcohen6