-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Column values sort #349
Column values sort #349
Conversation
@jtcohen6 — can I get your eyes on this. Namely, I'm curious whether |
Thinking only about the nomenclature, I'd feel equally fine about |
* Tidy up changelog * Add 0.7.0 entry to changelog * Add order_by argument to get_column_values (#349) * Add slugify macro to utils, use in pivot macro (#314) * 0.20.0 compatibility (#371) * Explicitly redefine Redshift -> default * Upgrade generic tests * Rm namespaces macro. New dispatch syntax * Run tests with 0.20.0rc1 * Update changelog, readme Co-authored-by: Jeremy Cohen <[email protected]> * Simplify concat (#373) * Postgres also have an alternative concat binary operation (#296) * Update default implementation of concat macro Co-authored-by: Christophe Duong <[email protected]> Co-authored-by: Jeremy Cohen <[email protected]> Co-authored-by: Christophe Duong <[email protected]>
Opening in place of #289 — needed to rebase to get it to work, and while I was here I simplified the implementation a little
This is a:
dev/
branchdev/
branch — changes positional argumenet orderDescription & motivation
Implement an
order_by
arg toget_column_values
. Fix up docs while hereChecklist