Update create_adapter_plugins.py #3509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtcohen6
requested review from
a team,
gshank and
kwigley
and removed request for
a team
gshank
approved these changes
Jun 29, 2021
kwigley
approved these changes
Jul 9, 2021
| @@ -232,12 +284,12 @@ def parse_args(argv=None): | |||
| parser.add_argument('adapter') | |||
| parser.add_argument('--title-case', '-t', default=None) | |||
| parser.add_argument('--dependency', action='append') | |||
| parser.add_argument('--dbt-core-version', default='0.16.1rc1') | |||
| parser.add_argument('--dbt-core-version', default='0.20.0rc1') | |||
There was a problem hiding this comment.
going to update this to 0.20.0rc2 to match current bumpversion
jtcohen6
force-pushed
the
update/adapter-plugin-script
branch
from
a6b2af3
to
21065e5
Compare
3 tasks
iknox-fa
pushed a commit
that referenced
this pull request
Feb 8, 2022
* Update create_adapter_plugins.py * Bump, changelog [skip ci] automatic commit by git-black, original commits: fb91bad
iknox-fa
pushed a commit
that referenced
this pull request
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3002
.bumpversion.cfg__version__.py,sample_profiles.yml,<myadapter>.dbtspecfind_namespace_packagesandMANIFEST.incookiecutter! There's so many arguments to this script, and I could imagine getting fancier and asking for credential members as well (to populate inconnections.py,sample_profiles.yml, and<myadapter>.dbtspec). I may take a crack at that, but I don't want to impede progress in the meantime.This PR does not include all the opinionated (and fairly tricky) logic that we have in
dbt-spark+dbt-prestoaround:__version__.py(as long as both are being bumped...)Checklist
This PR includes tests, or tests are not required/relevant for this PRCHANGELOG.mdand added information about my change to the "dbt next" section.