-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update create_adapter_plugins.py #3509
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not an area that I'm familiar with, but it looks pretty straightforward.
@@ -232,12 +284,12 @@ def parse_args(argv=None): | |||
parser.add_argument('adapter') | |||
parser.add_argument('--title-case', '-t', default=None) | |||
parser.add_argument('--dependency', action='append') | |||
parser.add_argument('--dbt-core-version', default='0.16.1rc1') | |||
parser.add_argument('--dbt-core-version', default='0.20.0rc1') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😮
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
going to update this to 0.20.0rc2 to match current bumpversion
a6b2af3
to
21065e5
Compare
* Update create_adapter_plugins.py * Bump, changelog [skip ci] automatic commit by git-black, original commits: fb91bad
resolves #3002
.bumpversion.cfg
__version__.py
,sample_profiles.yml
,<myadapter>.dbtspec
find_namespace_packages
andMANIFEST.in
cookiecutter
! There's so many arguments to this script, and I could imagine getting fancier and asking for credential members as well (to populate inconnections.py
,sample_profiles.yml
, and<myadapter>.dbtspec
). I may take a crack at that, but I don't want to impede progress in the meantime.This PR does not include all the opinionated (and fairly tricky) logic that we have in
dbt-spark
+dbt-presto
around:__version__.py
(as long as both are being bumped...)Checklist
This PR includes tests, or tests are not required/relevant for this PRCHANGELOG.md
and added information about my change to the "dbt next" section.