Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update create_adapter_plugins.py #3002

Closed
6 tasks
jtcohen6 opened this issue Jan 11, 2021 · 0 comments · Fixed by #3509
Closed
6 tasks

Update create_adapter_plugins.py #3002

jtcohen6 opened this issue Jan 11, 2021 · 0 comments · Fixed by #3509
Labels
1.0.0 Issues related to the 1.0.0 release of dbt adapter_plugins Issues relating to third-party adapter plugins enhancement New feature or request

Comments

@jtcohen6
Copy link
Contributor

jtcohen6 commented Jan 11, 2021

Improvements to create_adapter_plugins.py. Some of these are things we should do now, some are things we should seek to automate for future releases.

Versioning

  • Bump default core version to 0.19.0-rc1, add to .bumpversion.cfg
  • Create file dbt/adapters/[adapter]/__version__.py, to enable reporting from dbt --version
  • Codify our recommended practice: plugin versions should match dbt versions, with additional suffixes as needed. (E.g. here's how dbt-spark does it.) Change default package-version from 0.0.1 to match the core version, and add setup functions to effectuate.

Testing

  • Testing: Add scaffolding for test/[adapter].dbtspec, modeled off the postgres spec
  • Add scaffolding for dbt/include/[adapter]/sample_profiles.yml, which dbt will use to populate ~/.dbt/profiles.yml if a user installs the plugin and runs dbt init --adapter [adapter] for the first time. (We should make this work if they just run dbt init, too: dbt init --adapter default to the available adapter #2814)
  • Should the script accept/expect a connection_keys argument? If we did, we could use that to populate both of the above. Currently, we expect the user to add in these fields after running the scaffolding script.

Future: dbt Cloud

Eventually, we may want community plugin maintainers of community plugins to include:

  • "blessed" dockerfiles of runtime environments
  • JSONSchema of connection profile spec (same info as above)

This will enable us to support the plugin in dbt Cloud. We're still a ways away from that, but it's worth thinking about now in terms of the scaffolding we provide.

@jtcohen6 jtcohen6 added enhancement New feature or request adapter_plugins Issues relating to third-party adapter plugins labels Jan 11, 2021
@jtcohen6 jtcohen6 added the 1.0.0 Issues related to the 1.0.0 release of dbt label Jun 28, 2021
@jtcohen6 jtcohen6 self-assigned this Aug 2, 2021
@jtcohen6 jtcohen6 removed their assignment Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0.0 Issues related to the 1.0.0 release of dbt adapter_plugins Issues relating to third-party adapter plugins enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant