New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove leading whitespaces on post-hook operations #705

Merged

nicor88 merged 2 commits into dbt-labs:main from sanromeo:fix/vacuum-post-hook-lstrip

Aug 19, 2024

Contributor

sanromeo commented Aug 13, 2024 •

edited

Loading

Description

Resovles #704
On post-hook operation vacuum, optimize presented leading whitespaces in query, even if you config looks like this:

      +post-hook:
        - "vacuum {{ this }}"
        - "optimize {{ this }} rewrite data using bin_pack"

So, lstrip() method fix it

Checklist

You followed contributing section
You kept your Pull Request small and focused on a single feature or bug fix.
You added unit testing when necessary
You added functional testing when necessary


          fix: remove leading whitespaces on post-hook operations

6863ac4

sanromeo requested review from jessedobbelaere, Jrmyy, mattiamatrix, nicor88 and svdimchenko as code owners

August 13, 2024 15:45

nicor88 added the enable-functional-tests label

sanromeo mentioned this pull request

[Bug] Comment on post-hook vacuum, optimize operations #704

Closed

2 tasks

nicor88 reviewed

View reviewed changes

tests/unit/test_query_headers.py Show resolved Hide resolved


          Add unit-test for vacuum operation in lowercase

be2e805

sanromeo requested a review from nicor88

August 14, 2024 10:08

nicor88 approved these changes

View reviewed changes

nicor88 merged commit 3f4eee1 into dbt-labs:main

10 checks passed

kodiakhq bot referenced this pull request in cloudquery/policies


          fix(deps): Update dependency dbt-athena-community to v1.8.4 (#1057)

391d0d8

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [dbt-athena-community](https://github.com/dbt-athena/dbt-athena) | patch | `==1.8.3` -> `==1.8.4` |

---

### Release Notes

<details>
<summary>dbt-athena/dbt-athena (dbt-athena-community)</summary>

### [`v1.8.4`](https://github.com/dbt-athena/dbt-athena/releases/tag/v1.8.4)

[Compare Source](https://github.com/dbt-athena/dbt-athena/compare/v1.8.3...v1.8.4)

#### What's Changed

##### Fixes

-   fix: Remove catalog from the DDL SQL generated by on_schema_change=sync_all_columns by [@&#8203;iconara](https://github.com/iconara) in [https://github.com/dbt-athena/dbt-athena/pull/684](https://github.com/dbt-athena/dbt-athena/pull/684)
-   fix: Query comment for create table statement by [@&#8203;sanromeo](https://github.com/sanromeo) in [https://github.com/dbt-athena/dbt-athena/pull/702](https://github.com/dbt-athena/dbt-athena/pull/702)
-   fix: remove leading whitespaces on post-hook operations by [@&#8203;sanromeo](https://github.com/sanromeo) in [https://github.com/dbt-athena/dbt-athena/pull/705](https://github.com/dbt-athena/dbt-athena/pull/705)
-   fix: vacuum more runs needed error by [@&#8203;Jrmyy](https://github.com/Jrmyy) in [https://github.com/dbt-athena/dbt-athena/pull/703](https://github.com/dbt-athena/dbt-athena/pull/703)

##### Dependencies

-   chore: Update dbt-tests-adapter requirement from ~=1.9.1 to ~=1.9.2 by [@&#8203;dependabot](https://github.com/dependabot) in [https://github.com/dbt-athena/dbt-athena/pull/687](https://github.com/dbt-athena/dbt-athena/pull/687)
-   chore: Update pytest requirement from ~=8.2 to ~=8.3 by [@&#8203;dependabot](https://github.com/dependabot) in [https://github.com/dbt-athena/dbt-athena/pull/690](https://github.com/dbt-athena/dbt-athena/pull/690)
-   chore: Update pyupgrade requirement from ~=3.16 to ~=3.17 by [@&#8203;dependabot](https://github.com/dependabot) in [https://github.com/dbt-athena/dbt-athena/pull/692](https://github.com/dbt-athena/dbt-athena/pull/692)
-   chore: Update tenacity requirement from ~=8.2 to >=8.2,<10.0 by [@&#8203;dependabot](https://github.com/dependabot) in [https://github.com/dbt-athena/dbt-athena/pull/693](https://github.com/dbt-athena/dbt-athena/pull/693)
-   chore: Update black requirement from ~=24.4 to ~=24.8 by [@&#8203;dependabot](https://github.com/dependabot) in [https://github.com/dbt-athena/dbt-athena/pull/694](https://github.com/dbt-athena/dbt-athena/pull/694)
-   chore: Update boto3-stubs\[s3] requirement from ~=1.34 to ~=1.35 by [@&#8203;dependabot](https://github.com/dependabot) in [https://github.com/dbt-athena/dbt-athena/pull/707](https://github.com/dbt-athena/dbt-athena/pull/707)
-   chore: Update moto requirement from ~=5.0.12 to ~=5.0.13 by [@&#8203;dependabot](https://github.com/dependabot) in [https://github.com/dbt-athena/dbt-athena/pull/708](https://github.com/dbt-athena/dbt-athena/pull/708)
-   chore: Update pyparsing requirement from ~=3.1.2 to ~=3.1.4 by [@&#8203;dependabot](https://github.com/dependabot) in [https://github.com/dbt-athena/dbt-athena/pull/709](https://github.com/dbt-athena/dbt-athena/pull/709)

#### New Contributors

-   [@&#8203;iconara](https://github.com/iconara) made their first contribution in [https://github.com/dbt-athena/dbt-athena/pull/684](https://github.com/dbt-athena/dbt-athena/pull/684)

**Full Changelog**: dbt-labs/dbt-athena@v1.8.3...v1.8.4

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJhdXRvbWVyZ2UiXX0=-->

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

nicor88 nicor88 approved these changes

jessedobbelaere Awaiting requested review from jessedobbelaere

Jrmyy Awaiting requested review from Jrmyy

mattiamatrix Awaiting requested review from mattiamatrix

svdimchenko Awaiting requested review from svdimchenko

Labels

None yet