Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Comment on post-hook vacuum, optimize operations #704

Closed
2 tasks done
sanromeo opened this issue Aug 13, 2024 · 2 comments
Closed
2 tasks done

[Bug] Comment on post-hook vacuum, optimize operations #704

sanromeo opened this issue Aug 13, 2024 · 2 comments
Labels
type:bug Something isn't working

Comments

@sanromeo
Copy link
Contributor

Is this a new bug in dbt-athena?

  • I believe this is a new bug in dbt-athena
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

14:46:11 On model.data_models.table1:
vacuum "awsdatacatalog"."sandbox_roman_korsun"."table1"
-- /* {"app": "dbt", "dbt_version": "1.8.1", "profile_name": "athena", "target_name": "local" */

Expected Behavior

14:46:11 On model.data_models.table1: vacuum "awsdatacatalog"."sandbox_roman_korsun"."table1"

Steps To Reproduce

Write vaccum or optimize query in post-hook and run model with configured post-hook

Environment

- OS: -
- Python: 3.11.7
- dbt: 1.8.1
- dbt-athena-community: 1.8.3 (main branch)

Additional Context

No response

@sanromeo sanromeo added the type:bug Something isn't working label Aug 13, 2024
@nicor88
Copy link
Contributor

nicor88 commented Aug 13, 2024

@sanromeo isn't this a consequence of this PR #702?
looks like that the comment it's added, but for optimize and vacuum shouldn't be added.

@sanromeo
Copy link
Contributor Author

sanromeo commented Aug 13, 2024

@nicor88 yes, that are consequences of my previous PR, so I've created one more #705

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants