embedded-hal: 1.0.0-alpha.10 -> 1.0.0-rc.1

[newAM]

Closes #85
Closes #76

The embedded_hal blocking serial module was removed, it was replaced with embedded_io, but I think this makes more sense as a separate mock since it no longer has the Word generic.

[newAM]

I bumped the MSRV to fix this CI error: error: package tokio v1.31.0 cannot be built because it requires rustc 1.63 or newer, while the currently active rustc version is 1.60.0.

I could alternatively pin the version of tokio, or commit a lockfile and run CI with --locked

[tommy-gilligan]

Very exciting! I didn't know embedded-hal was at rc.1 now.

[vDorst]

I hope that this is merged soon, so I can point to this repo.
Have it running for a while.

[dbrgn]

Hi @newAM, I updated the main branch to fix CI and to bump the MSRV. Could you rebase your branch? (The second commit isn't needed anymore, you can drop it.)

[newAM]

Done! Should be all good-to-go now.

[rursprung]

@dbrgn: sorry to bother you, but is there a chance to get this (and other PRs in e-h-m) reviewed/merged/released? it'd be great to have a released version of this crate which matches the e-h release. thanks!

[dbrgn]

Thanks for the reminder, and sorry for the delay!

Looks good to me, only one documentation issue left. Afterwards it can be merged! I'll fix it myself, so we can merge directly.

[dbrgn]

Since these docs are for public users (which would import embedded_hal), I'd prefer to use the embedded_hal alias in here.

[dbrgn]

@newAM ah, seems I can't push to your branch. Could you apply the patch below and push an update?

diff --git a/src/eh1/spi.rs b/src/eh1/spi.rs
index 2c590d8..54bd591 100644
--- a/src/eh1/spi.rs
+++ b/src/eh1/spi.rs
@@ -8,7 +8,8 @@
 //! ## Usage
 //!
 //! ```
-//! use eh1::spi::SpiBus;
+//! # use eh1 as embedded_hal;
+//! use embedded_hal::spi::SpiBus;
 //! use embedded_hal_mock::eh1::spi::{Mock as SpiMock, Transaction as SpiTransaction};
 //! use embedded_hal_nb::spi::FullDuplex;
 //!
@@ -40,10 +41,8 @@
 //! // Finalise expectations
 //! spi.done();
 //! ```
-use eh1::spi;
-use eh1::spi::{Operation, SpiBus, SpiDevice};
-use embedded_hal_nb::nb;
-use embedded_hal_nb::spi::FullDuplex;
+use eh1::spi::{self, Operation, SpiBus, SpiDevice};
+use embedded_hal_nb::{nb, spi::FullDuplex};

 use crate::common::Generic;

[newAM]

Could you apply the patch below and push an update?

Done! :)

[rnestler]

A bit tangential, but maybe we should move this repository to a more "official" embedded rust GitHub organization to ease the maintenance burden on @dbrgn a bit?

[newAM]

I'm can also help out with maintenance if desired :)

[dbrgn]

@newAM thanks for the update! Ready for merge now 🙂

@rnestler @newAM I'm open for moving the repo to the rust-embedded organization, and also for adding more maintainers! Note that @ryankurte already has maintainer-rights here. @newAM I also invited you as collaborator 🙂 Thanks for the help!

[dbrgn]

This is now released as embedded-hal-mock version 0.10.0-rc.1: https://crates.io/crates/embedded-hal-mock/0.10.0-rc.1