update to embedded-hal=1.0.0-alpha.11
#76
Conversation
rursprung
force-pushed
the
embedded-hal-1.0.0-alpha.11
branch
from
2457d3a to
da84971
Compare
rursprung
force-pushed
the
embedded-hal-1.0.0-alpha.11
branch
2 times, most recently
from
8c42c04 to
f6748d0
Compare
see [their changelog][eh-changelog] for further details. [eh-changelog]: https://github.com/rust-embedded/embedded-hal/blob/v1.0.0-alpha.11/embedded-hal/CHANGELOG.md
rursprung
force-pushed
the
embedded-hal-1.0.0-alpha.11
branch
from
f6748d0 to
de956ee
Compare
|
thanks all for your feedback! i've now added a new transaction type |
| //! assert_eq!(spi.read().unwrap(), 0xFF); | ||
| //! FullDuplex::write(&mut spi, 0x09).expect("TODO: panic message"); | ||
| //! assert_eq!(FullDuplex::read(&mut spi).unwrap(), 0x0A); | ||
| //! FullDuplex::write(&mut spi, 0xFE).expect("TODO: panic message"); |
There was a problem hiding this comment.
Should these TODO messages be in here (i.e. are they TODOs for the reader)? Generally I'd just .unwrap() in example code.
|
|
||
| /// spi::TransferInplace implementation for Mock | ||
| /// | ||
| /// This writes the provided response to the buffer and will cause an assertion if the written data does not match the next expectation |
There was a problem hiding this comment.
Nitpick: The documentation is not correct anymore (the impl is for SpiBus, not TransferInplace). Also, it's a bit weird that there are docs only for one of the functions, not for the others.
If the documentation does not add much value, I'd remove it in this case for consistency reasons.
| Operation::DelayUs(delay) => { | ||
| let w = self | ||
| .next() | ||
| .expect("no expectation for spi::transaction call"); |
There was a problem hiding this comment.
This should probably be spi::delay?
| Operation::DelayUs(delay) => { | ||
| let w = self | ||
| .next() | ||
| .expect("no expectation for spi::transaction call"); |
There was a problem hiding this comment.
Again: This should probably be spi::delay?
|
Additionally, the changes from #75 were merged into |
|
@rursprung let me know if you want help with this :) |
|
I opened #85 with the feedback applied & rebased onto |
see their changelog for further details.