ui: remove 'compile_builtins'; to preserve previous behaviour users n…

…eed to use 'add_vhdl_builtins' (VUnit#559)

examples/vhdl/array/run.py

@@ -19,6 +19,7 @@
 from vunit import VUnit
 
 VU = VUnit.from_argv()
+VU.add_vhdl_builtins()
 VU.add_osvvm()
 
 SRC_PATH = Path(__file__).parent / "src"

examples/vhdl/array_axis_vcs/run.py

@@ -22,6 +22,7 @@
 from vunit import VUnit
 
 VU = VUnit.from_argv()
+VU.add_vhdl_builtins()
 VU.add_verification_components()
 
 SRC_PATH = Path(__file__).parent / "src"

examples/vhdl/axi_dma/run.py

@@ -21,6 +21,7 @@
 from vunit import VUnit
 
 VU = VUnit.from_argv()
+VU.add_vhdl_builtins()
 VU.add_osvvm()
 VU.add_verification_components()
 

examples/vhdl/check/run.py

@@ -17,6 +17,7 @@
 from vunit import VUnit
 
 VU = VUnit.from_argv()
+VU.add_vhdl_builtins()
 
 # Enable location preprocessing but exclude all but check_false to make the example less bloated
 VU.enable_location_preprocessing(

examples/vhdl/com/run.py

@@ -19,6 +19,7 @@
 from vunit import VUnit
 
 VU = VUnit.from_argv()
+VU.add_vhdl_builtins()
 VU.add_com()
 VU.add_verification_components()
 VU.add_osvvm()

examples/vhdl/composite_generics/run.py

@@ -22,6 +22,7 @@ def encode(tb_cfg):
 
 
 VU = VUnit.from_argv()
+VU.add_vhdl_builtins()
 
 TB_LIB = VU.add_library("tb_lib")
 TB_LIB.add_source_files(Path(__file__).parent / "test" / "*.vhd")

examples/vhdl/coverage/run.py

@@ -18,6 +18,7 @@ def post_run(results):
 
 
 VU = VUnit.from_argv()
+VU.add_vhdl_builtins()
 
 LIB = VU.add_library("lib")
 LIB.add_source_files(Path(__file__).parent / "*.vhd")

examples/vhdl/generate_tests/run.py

@@ -63,6 +63,8 @@ def generate_tests(obj, signs, data_widths):
 
 
 VU = VUnit.from_argv()
+VU.add_vhdl_builtins()
+
 LIB = VU.add_library("lib")
 LIB.add_source_files(Path(__file__).parent / "test" / "*.vhd")
 

examples/vhdl/json4vhdl/run.py

@@ -22,6 +22,7 @@
 TEST_PATH = Path(__file__).parent / "src" / "test"
 
 VU = VUnit.from_argv()
+VU.add_vhdl_builtins()
 VU.add_json4vhdl()
 
 LIB = VU.add_library("test")

examples/vhdl/logging/run.py

@@ -17,6 +17,8 @@
 from vunit import VUnit
 
 VU = VUnit.from_argv()
+VU.add_vhdl_builtins()
+
 VU.add_library("lib").add_source_files(Path(__file__).parent / "*.vhd")
 
 VU.main()

examples/vhdl/run/run.py

@@ -19,6 +19,7 @@
 ROOT = Path(__file__).parent
 
 VU = VUnit.from_argv()
+VU.add_vhdl_builtins()
 
 LIB = VU.add_library("lib")
 LIB.add_source_files(ROOT / "*.vhd")

examples/vhdl/third_party_integration/run.py

@@ -10,5 +10,8 @@
 from vunit import VUnit
 
 VU = VUnit.from_argv()
+VU.add_vhdl_builtins()
+
 VU.add_library("lib").add_source_files(Path(__file__).parent / "test" / "*.vhd")
+
 VU.main()

examples/vhdl/uart/run.py

@@ -18,6 +18,7 @@
 from vunit import VUnit
 
 VU = VUnit.from_argv()
+VU.add_vhdl_builtins()
 VU.add_osvvm()
 VU.add_verification_components()
 

examples/vhdl/user_guide/run.py

@@ -18,5 +18,8 @@
 from vunit import VUnit
 
 VU = VUnit.from_argv()
+VU.add_vhdl_builtins()
+
 VU.add_library("lib").add_source_files(Path(__file__).parent / "*.vhd")
+
 VU.main()

examples/vhdl/vivado/run.py

@@ -20,6 +20,7 @@
 SRC_PATH = ROOT / "src"
 
 VU = VUnit.from_argv()
+VU.add_vhdl_builtins()
 
 VU.add_library("lib").add_source_files(SRC_PATH / "*.vhd")
 VU.add_library("tb_lib").add_source_files(SRC_PATH / "test" / "*.vhd")

tests/unit/test_ui.py

@@ -1155,7 +1155,6 @@ def _create_ui_real_sim(self, *args):
         """Create an instance of the VUnit public interface class"""
         return VUnit.from_argv(
             argv=["--output-path=%s" % self._output_path, "--clean"] + list(args),
-            compile_builtins=False,
         )
 
     def _run_main(self, ui, code=0, post_run=None):

vunit/ui/__init__.py

@@ -58,14 +58,12 @@ class VUnit(object):  # pylint: disable=too-many-instance-attributes, too-many-p
     def from_argv(
         cls,
         argv=None,
-        compile_builtins: Optional[bool] = True,
         vhdl_standard: Optional[str] = None,
     ):
         """
         Create VUnit instance from command line arguments.
 
         :param argv: Use explicit argv instead of actual command line argument
-        :param compile_builtins: Do not compile builtins. Used for VUnit internal testing.
         :param vhdl_standard: The VHDL standard used to compile files,
                               if None the VUNIT_VHDL_STANDARD environment variable is used
         :returns: A :class:`.VUnit` object instance
@@ -79,13 +77,12 @@ def from_argv(
 
         """
         args = VUnitCLI().parse_args(argv=argv)
-        return cls.from_args(args, compile_builtins=compile_builtins, vhdl_standard=vhdl_standard)
+        return cls.from_args(args, vhdl_standard=vhdl_standard)
 
     @classmethod
     def from_args(
         cls,
         args,
-        compile_builtins: Optional[bool] = True,
         vhdl_standard: Optional[str] = None,
     ):
         """
@@ -95,18 +92,16 @@ def from_args(
         adding custom command line options.
 
         :param args: The parsed argument namespace object
-        :param compile_builtins: Do not compile builtins. Used for VUnit internal testing.
         :param vhdl_standard: The VHDL standard used to compile files,
                               if None the VUNIT_VHDL_STANDARD environment variable is used
         :returns: A :class:`.VUnit` object instance
 
         """
-        return cls(args, compile_builtins=compile_builtins, vhdl_standard=vhdl_standard)
+        return cls(args, vhdl_standard=vhdl_standard)
 
     def __init__(
         self,
         args,
-        compile_builtins: Optional[bool] = True,
         vhdl_standard: Optional[str] = None,
     ):
         self._args = args
@@ -156,8 +151,6 @@ def test_filter(name, attribute_names):
         self._test_bench_list = TestBenchList(database=database)
 
         self._builtins = Builtins(self, self._vhdl_standard, simulator_class)
-        if compile_builtins:
-            self.add_vhdl_builtins()
 
     def _create_database(self):
         """