fix(form elements): valid background- and border-colors
#5526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e8e8443 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-project-automation
bot
moved this to 🏗 In progress
in UX Engineering Team Backlog
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes form element validation styling by correcting color intensities and simplifying the conditional logic for displaying valid state borders.
- Updated color emphasis from 80 to 90 for valid/invalid floating labels
- Simplified valid state detection by removing the requirement for a visible success message to display the green border
Co-authored-by: Copilot <[email protected]>
mfranzke
moved this from 🏗 In progress
to 🎁 Ready for review
in UX Engineering Team Backlog
mfranzke
changed the title
valid background- and border-colors
github-actions
bot
added
the
📕documentation
sarahbrng
moved this from 🎁 Ready for review
to 👀 Actively In Review
in UX Engineering Team Backlog
sarahbrng
approved these changes
Nov 27, 2025
Contributor
sarahbrng
left a comment
sarahbrng
left a comment
There was a problem hiding this comment.
Could reproduce bug fix.
github-project-automation
bot
moved this from 👀 Actively In Review
to ⏰ready for release
in UX Engineering Team Backlog
github-project-automation
bot
moved this from ⏰ready for release
to ✅ Done
in UX Engineering Team Backlog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
resolves #5525
Reproduce this fix
To test and review this change, you could open https://design-system.deutschebahn.com/core-web/review/fix-form-elements-colors/components/data-input/select/overview?page=variant and need to set the validation manually (add
data-custom-validity="valid"-HTML-attribute toselect-HTML-element within the component) on those two types of components, and ensure that the messages isn't included. If you'd like to reproduce the setup out of the original issue #5525, you could set the classdb-color-yellowon a wrapping HTML element. This is resulting in the following rendering:Types of changes
Further comments
🔭🐙🐈 Test this branch here: https://design-system.deutschebahn.com/core-web/review/fix-form-elements-colors