Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
223aab0
chore: removed previous fonts
mfranzke Feb 21, 2023
510d76d
feat: added new icon fonts
mfranzke Feb 22, 2023
6f4effb
feat: added new icon fonts sources
mfranzke Feb 22, 2023
398d6f7
refactor: we won't need these "missing icons" fonts anymore
mfranzke Feb 22, 2023
d06924f
Merge branch 'main' into 425-adding-new-icons
mfranzke Feb 22, 2023
7b91ce1
refactor: we don't have a size relation by the font-families anymore
mfranzke Feb 22, 2023
20dd444
refactor: actually needed to add the correct version of these assets
mfranzke Feb 22, 2023
d5520ab
refactor: we don't need the mappings any more
mfranzke Feb 22, 2023
44f0f91
refactor: we won't need these "missing icons" fonts anymore
mfranzke Feb 22, 2023
80026ab
Merge branch '425-adding-new-icons' of https://github.com/db-ui/mono …
mfranzke Feb 22, 2023
60d37a8
refactor: needed to correct another aspect
mfranzke Feb 22, 2023
71ff43c
docs: how to create the icon fonts
mfranzke Feb 22, 2023
e4744e3
Update README.md
mfranzke Feb 23, 2023
6b16d6d
refactor: aligned the icons naming with the filenames
mfranzke Feb 23, 2023
ea2bd99
Merge branch 'main' into 425-adding-new-icons
mfranzke Feb 23, 2023
2c43d62
Merge branch 'main' into 425-adding-new-icons
mfranzke Feb 24, 2023
e93a51b
Merge branch 'main' into 425-adding-new-icons
mfranzke Feb 24, 2023
492a181
Merge branch 'main' into 425-adding-new-icons
mfranzke Feb 24, 2023
17b391e
Merge branch 'main' into 425-adding-new-icons
mfranzke Mar 14, 2023
23f72d2
Merge branch 'main' into 425-adding-new-icons
mfranzke Mar 24, 2023
541c99e
docs: added ADR 04 / icons
mfranzke Apr 4, 2023
ee3967f
Merge branch 'main' into 425-adding-new-icons
mfranzke Apr 4, 2023
f5ba4e4
Update adr-04-icons.md
mfranzke Jul 25, 2023
8cc50a4
Merge branch 'main' into 425-adding-new-icons
mfranzke Jul 25, 2023
152327d
Merge branch '425-adding-new-icons' of https://github.com/db-ui/mono …
mfranzke Jul 25, 2023
6141879
refactor: we shouldn't do this
mfranzke Jul 25, 2023
9a2aa27
Update adr-04-icons.md
mfranzke Jul 25, 2023
f58b664
Merge branch '425-adding-new-icons' of https://github.com/db-ui/mono …
mfranzke Jul 25, 2023
cc8d58b
refactor: regenerated types
mfranzke Jul 25, 2023
e2d7237
Update README.md
mfranzke Jul 25, 2023
5480a23
refactor: removed old sources files
mfranzke Jul 25, 2023
afa52f6
refactor: renamed those files
mfranzke Jul 25, 2023
24aa012
refactor: removed the old fonts
mfranzke Jul 25, 2023
d47a911
Merge branch 'main' into 425-adding-new-icons
mfranzke Jul 26, 2023
b31d890
Merge branch 'main' into 425-adding-new-icons
mfranzke Jul 26, 2023
6f45bfa
chore: update from main
nmerget Aug 25, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions docs/adr-04-icons.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
# ADR-04 - How to handle functional icons

_WIP_

## Decision and justification

We'll provide both SVG files, as well as icon fonts for total flexibility by the consuming developers. Out of our system we're focusing on referencing the latter, as this simplifies problems regarding e.g. referencing the assets at the correct path.

In general, these would be the ways how to reference a functional icon:
- Icons that we'd like to set based on the guidelines (like a specific icon for a specific variant, type or whatever): Via SCSS mixin, especially to separate markup from styling, and to ensure non-breaking update feasibility.
- Icons that the user could set: Either via SCSS mixin, or HTML attribute `data-icon`, depending on their tech stack.

## Problem description and context

## General conditions and decision criteria

### General conditions

### Decision criteria

- ...

## Alternatives

### A - Alternative name

#### Evaluation

### B - Alternative name

#### Evaluation

## Consequences

## Links



Loading