Skip to content

feat: added new icons #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mfranzke wants to merge 36 commits into from
Closed

feat: added new icons #509

mfranzke wants to merge 36 commits into from

Conversation

@mfranzke
Copy link
Collaborator

@mfranzke mfranzke commented Feb 22, 2023 •
edited
Loading

  • Removed previous icon name to glyph mapping, as we won't need this any more due to the usage of ligatures.
  • Removed icon font-family to icon-size relation, as the icons will scale through all sizes.
    • we need to revert this, as this will still be a thing.
  • Removed previous approach to deal with missing icons at a specific size with the missing-icons icon font.
  • outline -> outlined
  • Consolidate icon partial / icon placeholder and mixin.
  • Evaluate whether we need the tool svgo to optimize the icons first.

@mfranzke mfranzke added 📦foundations Changes inside foundations folder improvement labels Feb 22, 2023
@mfranzke mfranzke added this to the Guidelines 3.0 Beta milestone Feb 22, 2023
@mfranzke mfranzke self-assigned this Feb 22, 2023
@mfranzke mfranzke linked an issue Feb 22, 2023 that may be closed by this pull request
Adding new icons #425
Closed
@mfranzke mfranzke requested a review from annsch as a code owner February 22, 2023 06:09
@mfranzke mfranzke marked this pull request as draft February 22, 2023 06:09
@github-actions
Copy link
Contributor

github-actions bot commented Feb 22, 2023

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/425-adding-new-icons

mfranzke and others added 19 commits February 22, 2023 07:13
@mfranzke
feat: added new icon fonts
510d76d
@mfranzke
feat: added new icon fonts sources
6f4effb
@mfranzke
refactor: we won't need these "missing icons" fonts anymore
398d6f7 
they were a fallback for icons not existing in a specific size; ours will scale from now on.
@mfranzke
Merge branch 'main' into 425-adding-new-icons
d06924f
@mfranzke
refactor: we don't have a size relation by the font-families anymore
7b91ce1
@mfranzke
refactor: actually needed to add the correct version of these assets
20dd444
@mfranzke
refactor: we don't need the mappings any more
d5520ab 
due to using ligatures
@mfranzke
refactor: we won't need these "missing icons" fonts anymore
44f0f91
@mfranzke
Merge branch '425-adding-new-icons' of https://github.com/db-ui/mono …
80026ab 
…into 425-adding-new-icons
@mfranzke
refactor: needed to correct another aspect
60d37a8
@mfranzke
docs: how to create the icon fonts
71ff43c
@mfranzke
Update README.md
e4744e3
@mfranzke
refactor: aligned the icons naming with the filenames
6b16d6d
@mfranzke
Merge branch 'main' into 425-adding-new-icons
ea2bd99
@mfranzke
Merge branch 'main' into 425-adding-new-icons
2c43d62
@mfranzke
Merge branch 'main' into 425-adding-new-icons
e93a51b
@mfranzke
Merge branch 'main' into 425-adding-new-icons
492a181
@mfranzke
Merge branch 'main' into 425-adding-new-icons
17b391e
@mfranzke
Merge branch 'main' into 425-adding-new-icons
23f72d2
@mfranzke mfranzke mentioned this pull request Apr 4, 2023
Merged
@github-advanced-security
Copy link
Contributor

github-advanced-security bot commented Apr 4, 2023

You have successfully added a new CodeQL configuration .github/workflows/pull-request.yml:analyze/language:javascript. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@github-actions github-actions bot added 🧱components Changes inside components folder 📺showcases Changes to 1-n showcases labels Jul 25, 2023
@mfranzke
Copy link
Collaborator Author

mfranzke commented Aug 30, 2023

this PRs successor got merged half an hour ago: https://github.com/db-ui/mono/pull/1490

@mfranzke mfranzke closed this Aug 30, 2023
@nmerget nmerget deleted the 425-adding-new-icons branch September 19, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nmerget nmerget Awaiting requested review from nmerget

@dkolba dkolba Awaiting requested review from dkolba

@annsch annsch Awaiting requested review from annsch

Assignees

@mfranzke mfranzke

Labels

🧱components Changes inside components folder 📦foundations Changes inside foundations folder 📺showcases Changes to 1-n showcases

Projects

None yet

Milestone

Open Beta Release (0.1.0)

Development

Successfully merging this pull request may close these issues.

Adding new icons

3 participants

@mfranzke @nmerget