Drawcallui#4
Merged
Merged
Conversation
davo0411
added a commit
that referenced
this pull request
Oct 13, 2025
- Add PathHelpers namespace with GetSettingsTheme, GetThemesPath, GetFontsPath - Remove hardcoded path constants from State and SettingsOverrideManager - Add THEME config mode to State for theme file management - Add GetThemesRealPath for accessing theme directory on disk - Add stub LoadTheme/SaveTheme methods (full implementation in PR #4) This provides the foundation for the theme system by centralizing path management and removing hardcoded strings throughout the codebase. Part of UI modernization effort - PR #1 of 8 Related: - Blocks: PR #2 (Core UI Utilities) - See: PR_1530_SPLIT_PLAN.md for full breakdown Testing: - Verify existing configs still load correctly - Check that override paths resolve properly
davo0411
added a commit
that referenced
this pull request
Oct 13, 2025
…upport - Add PathHelpers namespace for consistent file system path handling - Implement theme JSON loading/saving system with validation - Add 9 theme presets (Default, Amber, DragonBlood, DwemerBronze, Forest, HighContrast, Light, NordicFrost, Ocean) - Add ThemeManager core for theme discovery and application - Add THEME config mode to State - Update SettingsOverrideManager to use PathHelpers - Integrate theme loading/saving into Menu - Add CreateDefaultThemes and theme discovery at plugin startup - Remove PR #2 files (Font system - to be added in next PR) - Remove PR #3 files (Settings UI overhaul - to be added in future PR) - Remove PR #4 files (UI candy/blur - to be added in future PR) - Remove PR #5 files (Performance overlay improvements - to be added in future PR)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.