Terrain variation asfeature#1
Merged
Merged
Conversation
Fixed small compile issue with PBR. No difference to visual effect.
Working Terrain Tiling Fix as a separate feature within Community Shaders. Has a on/off switch in the settings.
Works with or without terrainvariation plugin enabled now
Fix for weird issue with parallax terrain shadows causing the whole terrain to go black at certain distances.
Added checks for land weights, ensuring that sampling doesn't occur if it isn't needed. Should reduce overhead. Also tidied up the code, incorporating the blending of diffuse/rmaos/alpha into the layer code.
davo0411
added a commit
that referenced
this pull request
Oct 13, 2025
- Add PathHelpers namespace with GetSettingsTheme, GetThemesPath, GetFontsPath - Remove hardcoded path constants from State and SettingsOverrideManager - Add THEME config mode to State for theme file management - Add GetThemesRealPath for accessing theme directory on disk - Add stub LoadTheme/SaveTheme methods (full implementation in PR #4) This provides the foundation for the theme system by centralizing path management and removing hardcoded strings throughout the codebase. Part of UI modernization effort - PR #1 of 8 Related: - Blocks: PR #2 (Core UI Utilities) - See: PR_1530_SPLIT_PLAN.md for full breakdown Testing: - Verify existing configs still load correctly - Check that override paths resolve properly
davo0411
added a commit
that referenced
this pull request
Oct 13, 2025
- Add ColorUtils namespace with luminance/contrast calculation (WCAG compliant) - Add ContrastSelectable variants for automatic text contrast adjustment - Add GetContrastingTextColor for accessible UI text coloring - Add ButtonWithFlash for visual feedback on actions - Add FeatureToggle for clean minimalist on/off switches - Add restore-settings icon support (featureSettingRevert) - Update FeatureIssues to use FrameBorder for button styling - Improve category header styling with theme text colors - Add proper spacing between logo and text in headers These utilities provide the foundation for improved UI accessibility and visual polish throughout the menu system. Part of UI modernization effort - PR #2 of 8 Related: - Depends on: PR #1 (Foundation) - Blocks: PR #3 (Font System) - See: PR_1530_SPLIT_PLAN.md for full breakdown Testing: - Verify button flash animations work correctly - Test contrast calculation with various color combinations - Check that category headers render properly - Verify feature toggles respond to clicks
davo0411
added a commit
that referenced
this pull request
Oct 13, 2025
Combined PR #1 and PR #2 from split plan due to code integration. - Add PathHelpers namespace for consistent file system paths - Implement theme JSON loading/saving with validation - Add 9 theme presets + Font system with role-based architecture - Add 15+ font families with proper licensing - Font discovery, validation, and security (path traversal protection) - RAII font scope guards for semantic font roles - ThemeManager for theme/font management - Integrate into Menu, State, and plugin initialization - Remove blur shaders (reserved for future PR) - Revert Performance Overlay and Upscaling changes (reserved for future PRs)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.