Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add knip to avoid unused files, exports and deps #897

Merged
merged 5 commits into from
Nov 29, 2024

Conversation

davidlj95
Copy link
Owner

After #896 thought that maybe there is more unused code around. However, it's maybe not reported. To solve that, adding knip. It helps detecting unused files, exports and dependencies.

Just some configurations and it was ready to go! Found some unused things indeed.

The only change required was for data package not to be named @/data. As it incorrectly reports as being unused. Tried adding a dummy JS file to see if it was due to the weird TS hack to compile node_modules. But doesn't seem so.

Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.65%. Comparing base (0ced2c7) to head (e6fb81e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #897      +/-   ##
==========================================
- Coverage   97.65%   97.65%   -0.01%     
==========================================
  Files         122      122              
  Lines         598      597       -1     
  Branches       62       62              
==========================================
- Hits          584      583       -1     
  Misses         10       10              
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ignore JSONC trailing commas in WebStorm
remove conventional-changelog-conventionalcommits, hoist it instead
@davidlj95 davidlj95 enabled auto-merge (squash) November 29, 2024 20:14
@davidlj95 davidlj95 merged commit e9f0ba9 into main Nov 29, 2024
16 checks passed
@davidlj95 davidlj95 deleted the stacked/build-add-knip branch November 29, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant