chore: replace byComponent "by" By.directive & rm getComponentSelector

[davidlj95]

It does the same! However, our util was flakier, as it looked by the component selector. There have been some talking around to remove selectors. So using the DI system as By.directive does to look for the item is a stronger approach.

Then, getComponentSelector is only used by the test helper ensuring content projection is performed for the component. However, can get rid of that by specifying a custom selector for the component under test using TestBed.overrideComponent. So doing that and removing that function.

Finally, isClass can be removed as there are no usages of it

[davidlj95]

• chore: replace byComponent "by" By.directive & rm getComponentSelector #896 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.65%. Comparing base (acde337) to head (9221a4a).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #896      +/-   ##
==========================================
+ Coverage   96.71%   97.65%   +0.94%     
==========================================
  Files         124      122       -2     
  Lines         609      598      -11     
  Branches       66       62       -4     
==========================================
- Hits          589      584       -5     
+ Misses         16       10       -6     
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.