Skip to content

Fix stochastic restart bit for bit trouble #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davegill wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix stochastic restart bit for bit trouble #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d809c8
Look at stoch restart issues
davegill Mar 6, 2019
3e6301d
Stochastic restart bit4bot requires full dimensions for seeds and HRR…
judithberner Mar 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Registry/registry.dimspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ dimspec nndgvar - namelist=nobs_ndg_vars c nobs_ndg_vars
dimspec [ - namelist=obs_prt_max c obs_prt_max
dimspec obsstid - constant=40 c obs station id names
dimspec & 2 namelist=lagday z lagday
dimspec seed 1 namelist=seed_dim z seed_dim
endif


Expand Down
33 changes: 17 additions & 16 deletions Registry/registry.stoch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,14 +55,14 @@ state real SPPT_AMP ij misc 1 - r "SPPT_AMP" "amp


# 1d arrays
state real VERTAMPT k misc 1 - r "VERTAMPT" "vert. amplitude of stoch. temperature perturb." "" ""
state real VERTAMPUV k misc 1 - r "VERTAMPUV" "vert. amplitude of stoch. u,v perturb." "" ""
state integer ISEEDARR_SPPT k misc 1 - rh "ISEEDARR_SPPT" "Array to hold seed for restart, SPPT" "" ""
state integer ISEEDARR_SKEBS k misc 1 - rh "ISEEDARR_SKEBS" "Array to hold seed for restart, SKEBS" "" ""
state integer ISEEDARR_RAND_PERT k misc 1 - rh "ISEEDARR_RAND_PERTURB" "Array to hold seed for restart, RAND_PERT" "" ""
state integer iseedarr_spp_conv k misc 1 - rh "iseedarray_spp_conv" "Array to hold seed for restart, RAND_PERT2" "" ""
state integer iseedarr_spp_pbl k misc 1 - rh "iseedarray_spp_pbl" "Array to hold seed for restart, RAND_PERT3" "" ""
state integer iseedarr_spp_lsm k misc 1 - rh "iseedarray_spp_lsm" "Array to hold seed for restart, RAND_PERT4" "" ""
state real VERTAMPT k misc 1 - r "VERTAMPT" "vert. amplitude of stoch. temperature perturb." "" ""
state real VERTAMPUV k misc 1 - r "VERTAMPUV" "vert. amplitude of stoch. u,v perturb." "" ""
state integer ISEEDARR_SPPT {seed} misc 1 Z rh "ISEEDARR_SPPT" "Array to hold seed for restart, SPPT" "" ""
state integer ISEEDARR_SKEBS {seed} misc 1 Z rh "ISEEDARR_SKEBS" "Array to hold seed for restart, SKEBS" "" ""
state integer ISEEDARR_RAND_PERT {seed} misc 1 Z rh "ISEEDARR_RAND_PERTURB" "Array to hold seed for restart, RAND_PERT" "" ""
state integer iseedarr_spp_conv {seed} misc 1 Z rh "iseedarray_spp_conv" "Array to hold seed for restart, RAND_PERT2" "" ""
state integer iseedarr_spp_pbl {seed} misc 1 Z rh "iseedarray_spp_pbl" "Array to hold seed for restart, RAND_PERT3" "" ""
state integer iseedarr_spp_lsm {seed} misc 1 Z rh "iseedarray_spp_lsm" "Array to hold seed for restart, RAND_PERT4" "" ""

# 1d arrays for FFT transpose
state real RAND_REAL_xxx i{stoclev}jx dyn_em 1 XYZ
Expand Down Expand Up @@ -121,32 +121,32 @@ rconfig real gridpt_stddev_sppt namelist,stoch max_domains
rconfig real stddev_cutoff_sppt namelist,stoch max_domains 2.0 - "cutoff tails of pdf above this threshold standard deviation"
rconfig real lengthscale_sppt namelist,stoch max_domains 150000.0 - "Correlation length scale in meters for SPPT"
rconfig real timescale_sppt namelist,stoch max_domains 21600.0 - "Decorrelation time scale in s for SPPT"
rconfig integer sppt_vertstruc namelist,stoch 1 0 - "vertical structure for sppt: 0=constant, 1=random phase"
rconfig integer sppt_vertstruc namelist,stoch 1 0 - "vertical structure for sppt: 0=constant, 1=random phase"
rconfig integer iseed_sppt namelist,stoch 1 53 - "ISEED_SPPT" "RANDOM SEED FOR SPPT " ""

# Namelist parameters for random perturbations

rconfig integer rand_perturb namelist,stoch max_domains 0 - "generate array with random perturbations: 0=off, 1=on"
rconfig real gridpt_stddev_rand_pert namelist,stoch max_domains 0.03 - "gridpoint standard deviation of random perturbations"
rconfig real gridpt_stddev_rand_pert namelist,stoch max_domains 0.03 - "gridpoint standard deviation of random perturbations"
rconfig real stddev_cutoff_rand_pert namelist,stoch max_domains 3.0 - "cutoff tails of pdf above this threshold standard deviation"
rconfig real lengthscale_rand_pert namelist,stoch max_domains 500000.0 - "Correlation length scale in meters"
rconfig real timescale_rand_pert namelist,stoch max_domains 21600.0 - "Decorrelation time scale in s"
rconfig integer rand_pert_vertstruc namelist,stoch 1 0 - "vertical structure for random perturb: 0=constant, 1=random phase"
rconfig integer rand_pert_vertstruc namelist,stoch 1 0 - "vertical structure for random perturb: 0=constant, 1=random phase"
rconfig integer iseed_rand_pert namelist,stoch 1 17 - "ISEED_RAND_PERT" "RANDOM SEED FOR RAND_PERT " ""

# Namelist parameters for stochastic perturbed parameters

rconfig integer spp namelist,stoch max_domains 0 - "generate array with random perturbations: 0=off, 1=on"
rconfig logical hrrr_cycling namelist,stoch 1 .false. - "switch to control restart in quasi-cycled hrrr-forecasts"
rconfig logical hrrr_cycling namelist,stoch 1 .true. - "switch to control restart in quasi-cycled hrrr-forecasts"

# Namelist parameters for stochastic perturbed parameters (SPP) for convective scheme

rconfig integer spp_conv namelist,stoch max_domains 0 - "generate array with random perturbations: 0=off, 1=on"
rconfig integer spp_conv namelist,stoch max_domains 0 - "generate array with random perturbations: 0=off, 1=on"
rconfig real gridpt_stddev_spp_conv namelist,stoch max_domains 0.3 - "gridpoint standard deviation of random perturbations"
rconfig real stddev_cutoff_spp_conv namelist,stoch max_domains 3.0 - "cutoff tails of pdf above this threshold standard deviation"
rconfig real lengthscale_spp_conv namelist,stoch max_domains 150000.0 - "Correlation length scale in meters"
rconfig real timescale_spp_conv namelist,stoch max_domains 21600.0 - "Decorrelation time scale in s"
rconfig integer vertstruc_spp_conv namelist,stoch 1 0 - "vertical structure for random perturb: 0=constant, 1=random phase"
rconfig integer vertstruc_spp_conv namelist,stoch 1 0 - "vertical structure for random perturb: 0=constant, 1=random phase"
rconfig integer iseed_spp_conv namelist,stoch 1 171 - "ISEED_RAND_PERT" "RANDOM SEED FOR RAND_PERT " ""

# Namelist parameters for stochastic perturbed parameters (SPP) for pbl
Expand All @@ -156,7 +156,7 @@ rconfig real gridpt_stddev_spp_pbl namelist,stoch max_domains
rconfig real stddev_cutoff_spp_pbl namelist,stoch max_domains 2.0 - "cutoff tails of pdf above this threshold standard deviation"
rconfig real lengthscale_spp_pbl namelist,stoch max_domains 700000.0 - "Correlation length scale in meters"
rconfig real timescale_spp_pbl namelist,stoch max_domains 21600.0 - "Decorrelation time scale in s"
rconfig integer vertstruc_spp_pbl namelist,stoch 1 0 - "vertical structure for random perturb: 0=constant, 1=random phase"
rconfig integer vertstruc_spp_pbl namelist,stoch 1 0 - "vertical structure for random perturb: 0=constant, 1=random phase"
rconfig integer iseed_spp_pbl namelist,stoch 1 217 - "ISEED_RAND_PERT" "RANDOM SEED FOR RAND_PERT " ""


Expand All @@ -167,7 +167,7 @@ rconfig real gridpt_stddev_spp_lsm namelist,stoch max_domains
rconfig real stddev_cutoff_spp_lsm namelist,stoch max_domains 3.0 - "cutoff tails of pdf above this threshold standard deviation"
rconfig real lengthscale_spp_lsm namelist,stoch max_domains 50000.0 - "Correlation length scale in meters"
rconfig real timescale_spp_lsm namelist,stoch max_domains 86400.0 - "Decorrelation time scale in s"
rconfig integer vertstruc_spp_lsm namelist,stoch 1 0 - "vertical structure for random perturb: 0=constant, 1=random phase"
rconfig integer vertstruc_spp_lsm namelist,stoch 1 0 - "vertical structure for random perturb: 0=constant, 1=random phase"
rconfig integer iseed_spp_lsm namelist,stoch 1 317 - "ISEED_RAND_PERT" "RANDOM SEED FOR RAND_PERT " ""

# Derived namelist parameters used in share/module_check_amundo.F
Expand All @@ -177,6 +177,7 @@ rconfig integer sppt_on derived 1 0 - "sp
rconfig integer spp_on derived 1 0 - "skebs_on" "skebs arrays are declared&filled for all domains" ""
rconfig integer rand_perturb_on derived 1 0 - "rand_perturb_on " "random perturb. array is declared&filled for all domains" ""
rconfig integer num_stoch_levels derived 1 1 - "num_stoch_levels" "number of vertical levels of random fields" ""
rconfig integer seed_dim derived 1 0 - "seed_dim" "output of CALL RANDOM_SEED(SIZE=seed_dim)" ""

# Package declarations

Expand Down
20 changes: 14 additions & 6 deletions dyn_em/module_first_rk_step_part2.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ SUBROUTINE first_rk_step_part2 ( grid , config_flags &
grid%num_stoch_levels,grid%num_stoch_levels, &
grid%num_stoch_levels,grid%num_stoch_levels, &
config_flags%restart, grid%iseedarr_skebs, &
config_flags%seed_dim, &
grid%DX,grid%DY,grid%skebs_vertstruc, &
grid%rt_tendf_stoch, &
grid%stddev_cutoff_sppt,grid%gridpt_stddev_sppt, &
Expand All @@ -181,6 +182,7 @@ SUBROUTINE first_rk_step_part2 ( grid , config_flags &
grid% num_stoch_levels,grid% num_stoch_levels, &
grid% num_stoch_levels,grid% num_stoch_levels, &
config_flags%restart, grid%iseedarr_skebs, &
config_flags%seed_dim, &
grid%DX,grid%DY,grid%skebs_vertstruc, &
grid%ru_tendf_stoch, &
grid%stddev_cutoff_sppt,grid%gridpt_stddev_sppt, &
Expand All @@ -200,6 +202,7 @@ SUBROUTINE first_rk_step_part2 ( grid , config_flags &
grid% num_stoch_levels,grid% num_stoch_levels, &
grid% num_stoch_levels,grid% num_stoch_levels, &
config_flags%restart, grid%iseedarr_skebs, &
config_flags%seed_dim, &
grid%DX,grid%DY,grid%skebs_vertstruc, &
grid%rv_tendf_stoch, &
grid%stddev_cutoff_sppt,grid%gridpt_stddev_sppt, &
Expand All @@ -221,6 +224,7 @@ SUBROUTINE first_rk_step_part2 ( grid , config_flags &
grid%num_stoch_levels,grid%num_stoch_levels, &
grid%num_stoch_levels,grid%num_stoch_levels, &
config_flags%restart, grid%iseedarr_sppt, &
config_flags%seed_dim, &
grid%DX,grid%DY,grid%sppt_vertstruc, &
grid%rstoch, &
grid%stddev_cutoff_sppt,grid%gridpt_stddev_sppt, &
Expand All @@ -242,6 +246,7 @@ SUBROUTINE first_rk_step_part2 ( grid , config_flags &
grid%num_stoch_levels,grid%num_stoch_levels, &
grid%num_stoch_levels,grid%num_stoch_levels, &
config_flags%restart, grid%iseedarr_rand_pert, &
config_flags%seed_dim, &
grid%DX,grid%DY,grid%rand_pert_vertstruc, &
grid%RAND_PERT, &
grid%stddev_cutoff_rand_pert,grid%gridpt_stddev_rand_pert, &
Expand All @@ -261,9 +266,10 @@ SUBROUTINE first_rk_step_part2 ( grid , config_flags &
ipsy,ipey,jpsy,jpey,kpsy,kpey, &
grid%num_stoch_levels,grid%num_stoch_levels, &
grid%num_stoch_levels,grid%num_stoch_levels, &
config_flags%restart, grid%iseedarr_spp_conv, &
config_flags%restart, grid%iseedarr_spp_conv, &
config_flags%seed_dim, &
grid%DX,grid%DY,grid%vertstruc_spp_conv, &
grid%pattern_spp_conv, &
grid%pattern_spp_conv, &
grid%stddev_cutoff_spp_conv,grid%gridpt_stddev_spp_conv, &
grid%VERTSTRUCC,grid%VERTSTRUCS,grid%VERTAMPT )
ENDIF !spp_conv
Expand All @@ -281,9 +287,10 @@ SUBROUTINE first_rk_step_part2 ( grid , config_flags &
ipsy,ipey,jpsy,jpey,kpsy,kpey, &
grid%num_stoch_levels,grid%num_stoch_levels, &
grid%num_stoch_levels,grid%num_stoch_levels, &
config_flags%restart, grid%iseedarr_spp_pbl, &
config_flags%restart, grid%iseedarr_spp_pbl, &
config_flags%seed_dim, &
grid%DX,grid%DY,grid%vertstruc_spp_pbl, &
grid%pattern_spp_pbl, &
grid%pattern_spp_pbl, &
grid%stddev_cutoff_spp_pbl,grid%gridpt_stddev_spp_pbl, &
grid%VERTSTRUCC,grid%VERTSTRUCS,grid%VERTAMPT )
ENDIF !spp_pbl
Expand All @@ -301,9 +308,10 @@ SUBROUTINE first_rk_step_part2 ( grid , config_flags &
ipsy,ipey,jpsy,jpey,kpsy,kpey, &
grid%num_stoch_levels,grid%num_stoch_levels, &
grid%num_stoch_levels,grid%num_stoch_levels, &
config_flags%restart, grid%iseedarr_spp_lsm, &
config_flags%restart, grid%iseedarr_spp_lsm, &
config_flags%seed_dim, &
grid%DX,grid%DY,grid%vertstruc_spp_lsm, &
grid%pattern_spp_lsm, &
grid%pattern_spp_lsm, &
grid%stddev_cutoff_spp_lsm,grid%gridpt_stddev_spp_lsm, &
grid%VERTSTRUCC,grid%VERTSTRUCS,grid%VERTAMPT )
ENDIF !spp_lsm
Expand Down
Loading