Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: stochastic, restart, b4b, hrrr_cycling
SOURCE: Judith Berner (NCAR), internal
DESCRIPTION OF CHANGES:
seed_dimISSUE: For use when this PR closes an issue. For issue number 123
LIST OF MODIFIED FILES:
M Registry/registry.dimspec
M Registry/registry.stoch
M dyn_em/module_first_rk_step_part2.F
M dyn_em/module_stoch.F
M share/module_check_a_mundo.F
TESTS CONDUCTED:
:thumbs_up:
RELEASE NOTE: After hrrr_cycling was introduced to WRF, the stochastic solutions were not bit reproducible with a restart. Also, with newer compilers, the size of the seed array exceeded the vertical dimensions in WRF. Both have been addressed.