Skip to content

Fix stochastic restart bit for bit trouble#4

Open
davegill wants to merge 2 commits intodevelopfrom
stoch_seeds
Open

Fix stochastic restart bit for bit trouble#4
davegill wants to merge 2 commits intodevelopfrom
stoch_seeds

Conversation

@davegill
Copy link
Owner

@davegill davegill commented Mar 6, 2019

TYPE: bug fix

KEYWORDS: stochastic, restart, b4b, hrrr_cycling

SOURCE: Judith Berner (NCAR), internal

DESCRIPTION OF CHANGES:

  1. Made the random number seed to have a dimension that is intrinsic to the compiler.
  2. Force hrrr_cycling = .true. to avoid resetting seeds on restart.
  3. The seeds now have a "Z" stagger (no zero value in last entry).
  4. Modify code to accommodate the swap from vertical dimension of seed to the new seed_dim

ISSUE: For use when this PR closes an issue. For issue number 123

Fixes #123

LIST OF MODIFIED FILES:
M Registry/registry.dimspec
M Registry/registry.stoch
M dyn_em/module_first_rk_step_part2.F
M dyn_em/module_stoch.F
M share/module_check_a_mundo.F

TESTS CONDUCTED:

  1. The patterns are identical after a restart.
    :thumbs_up:

RELEASE NOTE: After hrrr_cycling was introduced to WRF, the stochastic solutions were not bit reproducible with a restart. Also, with newer compilers, the size of the seed array exceeded the vertical dimensions in WRF. Both have been addressed.

@judithberner judithberner changed the title Look at stoch restart issues Fix stochastic restart bit for bit trouble Mar 6, 2019
@judithberner judithberner changed the base branch from master to develop March 6, 2019 23:18
davegill added a commit that referenced this pull request Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants