Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing job ownership transfer logic in Update-SqlPermission #5301

Merged
merged 1 commit into from
Mar 25, 2019
Merged

Fixing job ownership transfer logic in Update-SqlPermission #5301

merged 1 commit into from
Mar 25, 2019

Conversation

nvarscar
Copy link
Contributor

Type of Change

  • Bug fix (non-breaking change, fixes an issue from slack)
  • New feature (non-breaking change, adds functionality)
  • Breaking change (effects multiple commands or functionality)
  • Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
  • Nunit test is included
  • Documentation
  • Build system

Purpose

Fix a logic error when transferring job ownership

Approach

Fixing a typo

Commands to test

Screenshots

Learning

@potatoqualitee
Copy link
Member

fantastic! thanks much @nvarscar

@potatoqualitee potatoqualitee merged commit a6344a2 into development Mar 25, 2019
@potatoqualitee
Copy link
Member

going to publish tonight after i make a few changes

@potatoqualitee potatoqualitee deleted the ownedjobs-fix branch March 25, 2019 20:16
potatoqualitee added a commit that referenced this pull request Mar 26, 2019
@potatoqualitee
0.9.797 (#5306)
758ed02 
* add additional exclusion tag

excluding Solution Provided tag

* fixes #5287

* Set-DbaStartupParameter - getting 1.0 ready (#5298)

* Merge pull request #5157 from SQLGB/patch-1

Update Get-DbaAgentJobHistory.ps1

* format, add catch for call to get cmd

* change parameter to singular

* correct parameter names in test

* updating parameter reference

* adjust appveyor reference

* quick fix for copy startup proc

format and spelling

* Update issue templates

Updating template on bug reports

* Update issue templates

adding wrapper command to gather info and allow them to paste it

* fixing owned job comparison (#5301)

* 0.9.797
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nvarscar @potatoqualitee