Set-DbaStartupParameter - getting 1.0 ready #5298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Get-DbaAgentJobHistory.ps1
|
Ok, as long as test pass everything is good to go on this one... |
wsmelton
commented
Mar 24, 2019
| } catch { | ||
| Stop-Function -Message "Unable to gather current startup parameters" -Target $SqlInstance -ErrorRecord $_ | ||
| return | ||
| } |
There was a problem hiding this comment.
This is particularly important to do anytime we are calling other public functions in our commands. Because this was not including EnableException and wrapped in a try/catch it was falsely assuming SingleUser was true at current line 237 because the object didn't have any content to begin with.... so if (!($currentStartup.SingleUser)) will return true when that property is true AND when $currentStartup -eq $null ...so the object itself had no content.
|
Had to add few quick fixes for the copy startup proc command that I found missed. |
|
looks good, ty! |
potatoqualitee
added a commit
that referenced
this pull request
Mar 26, 2019
* add additional exclusion tag excluding Solution Provided tag * fixes #5287 * Set-DbaStartupParameter - getting 1.0 ready (#5298) * Merge pull request #5157 from SQLGB/patch-1 Update Get-DbaAgentJobHistory.ps1 * format, add catch for call to get cmd * change parameter to singular * correct parameter names in test * updating parameter reference * adjust appveyor reference * quick fix for copy startup proc format and spelling * Update issue templates Updating template on bug reports * Update issue templates adding wrapper command to gather info and allow them to paste it * fixing owned job comparison (#5301) * 0.9.797
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Purpose
Working through #5292 and overall getting ready for 1.0 (e.g. apply standard on formatting, try/catch around child calls to other dbatools commands, etc.)