Fixed ImportDbaCsv for non default SqlBulkCopyOptions

bin/smo/smo-deps.txt

@@ -16,4 +16,4 @@ dir | %{
     try { Add-Type -Path $_.FullName -ErrorAction Stop }
     catch { $_.Exception.LoaderExceptions.FileName | %{ $dep += $_ }}
 }
-$dep | select -unique
+$dep | Select-Object -unique

en-us/about_dbatools_support.help.txt

@@ -93,7 +93,7 @@ LONG DESCRIPTION
 	most valuable piece of information for troubleshooting. Generally, you can
 	see that exception content by running the following line:
 
-	  $error[0] | Select *
+	  $error[0] | Select-Object *
 
 	Directly after the command failed. Screenshot it.
 

functions/ConvertTo-DbaXESession.ps1

@@ -33,7 +33,7 @@ function ConvertTo-DbaXESession {
         License: MIT https://opensource.org/licenses/MIT
 
     .EXAMPLE
-        PS C:\> Get-DbaTrace -SqlInstance sql2017, sql2012 | Where Id -eq 2 | ConvertTo-DbaXESession -Name 'Test'
+        PS C:\> Get-DbaTrace -SqlInstance sql2017, sql2012 | Where-Object Id -eq 2 | ConvertTo-DbaXESession -Name 'Test'
 
         Converts Trace with ID 2 to a Session named Test on SQL Server instances named sql2017 and sql2012 and creates the Session on each respective server.
 
@@ -43,7 +43,7 @@ function ConvertTo-DbaXESession {
         Converts selected traces on sql2014 to sessions, creates the session, and starts it.
 
     .EXAMPLE
-        PS C:\> Get-DbaTrace -SqlInstance sql2014 | Where Id -eq 1 | ConvertTo-DbaXESession -Name 'Test' -OutputScriptOnly
+        PS C:\> Get-DbaTrace -SqlInstance sql2014 | Where-Object Id -eq 1 | ConvertTo-DbaXESession -Name 'Test' -OutputScriptOnly
 
         Converts trace ID 1 on sql2014 to an Extended Event and outputs the resulting T-SQL.
 

functions/Get-DbaAvailabilityGroup.ps1

@@ -48,7 +48,7 @@ function Get-DbaAvailabilityGroup {
         Shows basic information on the Availability Group AG-a on sqlserver2014a.
 
     .EXAMPLE
-        PS C:\> Get-DbaAvailabilityGroup -SqlInstance sqlserver2014a | Select *
+        PS C:\> Get-DbaAvailabilityGroup -SqlInstance sqlserver2014a | Select-Object *
 
         Returns full object properties on all Availability Group(s) on sqlserver2014a.
 

functions/Get-DbaClientProtocol.ps1

@@ -47,7 +47,7 @@ function Get-DbaClientProtocol {
         Gets the SQL Server related client protocols on computers sql1 and sql2, and shows them in a grid view.
 
     .EXAMPLE
-        PS C:\> (Get-DbaClientProtocol -ComputerName sql2 | Where { $_.DisplayName = 'via' }).Disable()
+        PS C:\> (Get-DbaClientProtocol -ComputerName sql2 | Where-Object { $_.DisplayName = 'via' }).Disable()
 
         Disables the VIA ClientNetworkProtocol on computer sql2.
         If successful, return code 0 is shown.

functions/Get-DbaCpuRingBuffer.ps1

@@ -52,7 +52,7 @@ function Get-DbaCpuRingBuffer {
         Gets CPU Statistics from sys.dm_os_ring_buffers for server sql2008 for last 240 minutes
 
     .EXAMPLE
-        PS C:\> $output = Get-DbaCpuRingBuffer -SqlInstance sql2008 -CollectionMinutes 240 | Select * | ConvertTo-DbaDataTable
+        PS C:\> $output = Get-DbaCpuRingBuffer -SqlInstance sql2008 -CollectionMinutes 240 | Select-Object * | ConvertTo-DbaDataTable
 
         Gets CPU Statistics from sys.dm_os_ring_buffers for server sql2008 for last 240 minutes into a Data Table.
 

functions/Get-DbaDbMail.ps1

@@ -34,7 +34,7 @@ function Get-DbaDbMail {
         Returns the db mail server object on sql01\sharepoint
 
     .EXAMPLE
-        PS C:\> Get-DbaDbMail -SqlInstance sql01\sharepoint | Select *
+        PS C:\> Get-DbaDbMail -SqlInstance sql01\sharepoint | Select-Object *
 
         Returns the db mail server object on sql01\sharepoint then return a bunch more columns
 

functions/Get-DbaDbMailAccount.ps1

@@ -48,7 +48,7 @@ function Get-DbaDbMailAccount {
         Returns The DBA Team Database Mail account from sql01\sharepoint
 
     .EXAMPLE
-        PS C:\> Get-DbaDbMailAccount -SqlInstance sql01\sharepoint | Select *
+        PS C:\> Get-DbaDbMailAccount -SqlInstance sql01\sharepoint | Select-Object *
 
         Returns the Database Mail accounts on sql01\sharepoint then return a bunch more columns
 

functions/Get-DbaDbMailConfig.ps1

@@ -45,7 +45,7 @@ function Get-DbaDbMailConfig {
         Returns the ProhibitedExtensions configuration on sql01\sharepoint
 
     .EXAMPLE
-        PS C:\> Get-DbaDbMailConfig -SqlInstance sql01\sharepoint | Select *
+        PS C:\> Get-DbaDbMailConfig -SqlInstance sql01\sharepoint | Select-Object *
 
         Returns the DBMail configs on sql01\sharepoint then return a bunch more columns
 

functions/Get-DbaDbMailHistory.ps1

@@ -40,7 +40,7 @@ function Get-DbaDbMailHistory {
         Returns the entire DBMail history on sql01\sharepoint
 
     .EXAMPLE
-        PS C:\> Get-DbaDbMailHistory -SqlInstance sql01\sharepoint | Select *
+        PS C:\> Get-DbaDbMailHistory -SqlInstance sql01\sharepoint | Select-Object *
 
         Returns the entire DBMail history on sql01\sharepoint then return a bunch more columns
 

functions/Get-DbaDbMailLog.ps1

@@ -40,7 +40,7 @@ function Get-DbaDbMailLog {
         Returns the entire DBMail log on sql01\sharepoint
 
     .EXAMPLE
-        PS C:\> Get-DbaDbMailLog -SqlInstance sql01\sharepoint | Select *
+        PS C:\> Get-DbaDbMailLog -SqlInstance sql01\sharepoint | Select-Object *
 
         Returns the entire DBMail log on sql01\sharepoint, includes all returned information.
 

functions/Get-DbaDbMailProfile.ps1

@@ -48,7 +48,7 @@ function Get-DbaDbMailProfile {
         Returns The DBA Team DBMail profile from sql01\sharepoint
 
     .EXAMPLE
-        PS C:\> Get-DbaDbMailProfile -SqlInstance sql01\sharepoint | Select *
+        PS C:\> Get-DbaDbMailProfile -SqlInstance sql01\sharepoint | Select-Object *
 
         Returns the DBMail profiles on sql01\sharepoint then return a bunch more columns
 

functions/Get-DbaDbMailServer.ps1

@@ -48,7 +48,7 @@ function Get-DbaDbMailServer {
         Returns The DBA Team DBMail server from sql01\sharepoint
 
     .EXAMPLE
-        PS C:\> Get-DbaDbMailServer -SqlInstance sql01\sharepoint | Select *
+        PS C:\> Get-DbaDbMailServer -SqlInstance sql01\sharepoint | Select-Object *
 
         Returns the DBMail servers on sql01\sharepoint then return a bunch more columns
 

functions/Get-DbaDependency.ps1

@@ -46,7 +46,7 @@ function Get-DbaDependency {
         https://dbatools.io/Get-DbaDependency
 
     .EXAMPLE
-        PS C:\> $table = (Get-DbaDatabase -SqlInstance sql2012 -Database Northwind).tables | Where Name -eq Customers
+        PS C:\> $table = (Get-DbaDatabase -SqlInstance sql2012 -Database Northwind).tables | Where-Object Name -eq Customers
         PS C:\> $table | Get-DbaDependency
 
         Returns everything that depends on the "Customers" table

functions/Get-DbaEstimatedCompletionTime.ps1

@@ -58,7 +58,7 @@ function Get-DbaEstimatedCompletionTime {
         Gets estimated completion times for queries performed against the entire server
 
     .EXAMPLE
-        PS C:\> Get-DbaEstimatedCompletionTime -SqlInstance sql2016 | Select *
+        PS C:\> Get-DbaEstimatedCompletionTime -SqlInstance sql2016 | Select-Object *
 
         Gets estimated completion times for queries performed against the entire server PLUS the SQL query text of each command
 

functions/Get-DbaIoLatency.ps1

@@ -39,7 +39,7 @@ function Get-DbaIoLatency {
         Get IO subsystem latency statistics for servers sql2008 and sqlserver2012.
 
     .EXAMPLE
-        PS C:\> $output = Get-DbaIoLatency -SqlInstance sql2008 | Select * | ConvertTo-DbaDataTable
+        PS C:\> $output = Get-DbaIoLatency -SqlInstance sql2008 | Select-Object * | ConvertTo-DbaDataTable
 
         Collects all IO subsystem latency statistics on server sql2008 into a Data Table.
 

functions/Get-DbaLastBackup.ps1

@@ -46,12 +46,12 @@ function Get-DbaLastBackup {
         Returns a custom object with Server name, Database name, and the date the last time backups were performed.
 
     .EXAMPLE
-        PS C:\> Get-DbaLastBackup -SqlInstance ServerA\sql987 | Select *
+        PS C:\> Get-DbaLastBackup -SqlInstance ServerA\sql987 | Select-Object *
 
         Returns a custom object with Server name, Database name, and the date the last time backups were performed, and also recoverymodel and calculations on how long ago backups were taken and what the status is.
 
     .EXAMPLE
-        PS C:\> Get-DbaLastBackup -SqlInstance ServerA\sql987 | Select * | Out-Gridview
+        PS C:\> Get-DbaLastBackup -SqlInstance ServerA\sql987 | Select-Object * | Out-Gridview
 
         Returns a gridview displaying Server, Database, RecoveryModel, LastFullBackup, LastDiffBackup, LastLogBackup, SinceFull, SinceDiff, SinceLog, Status, DatabaseCreated, DaysSinceDbCreated.
 

functions/Get-DbaLatchStatistic.ps1

@@ -53,7 +53,7 @@ function Get-DbaLatchStatistic {
         Check latch statistics on server sql2008 for thresholds above 98%
 
     .EXAMPLE
-        PS C:\> $output = Get-DbaLatchStatistic -SqlInstance sql2008 -Threshold 100 | Select * | ConvertTo-DbaDataTable
+        PS C:\> $output = Get-DbaLatchStatistic -SqlInstance sql2008 -Threshold 100 | Select-Object * | ConvertTo-DbaDataTable
 
         Collects all latch statistics on server sql2008 into a Data Table.
 

functions/Get-DbaModule.ps1

@@ -53,7 +53,7 @@ function Get-DbaModule {
         Return all modules for servers sql2008 and sqlserver2012 sorted by Database, Modify_Date ASC.
 
     .EXAMPLE
-        PS C:\> Get-DbaModule -SqlInstance sql2008, sqlserver2012 | Select *
+        PS C:\> Get-DbaModule -SqlInstance sql2008, sqlserver2012 | Select-Object *
 
         Shows hidden definition column (informative wall of text).
 

functions/Get-DbaMsdtc.ps1

@@ -35,7 +35,7 @@ function Get-DbaMsdtc {
         Get DTC status for all the computers in a .txt file
 
     .EXAMPLE
-        PS C:\> Get-DbaMsdtc -Computername $Computers | where { $_.dtcservicestate -ne 'running' }
+        PS C:\> Get-DbaMsdtc -Computername $Computers | Where-Object { $_.dtcservicestate -ne 'running' }
 
         Get DTC status for all the computers where the MSDTC Service is not running
 

functions/Get-DbaServerProtocol.ps1

@@ -47,7 +47,7 @@ function Get-DbaServerProtocol {
         Gets the SQL Server related server protocols on computers sql1 and sql2, and shows them in a grid view.
 
     .EXAMPLE
-        PS C:\> (Get-DbaServerProtocol -ComputerName sql1 | Where { $_.DisplayName = 'via' }).Disable()
+        PS C:\> (Get-DbaServerProtocol -ComputerName sql1 | Where-Object { $_.DisplayName = 'via' }).Disable()
 
         Disables the VIA ServerNetworkProtocol on computer sql1.
         If successful, return code 0 is shown.

functions/Get-DbaSpinLockStatistic.ps1

@@ -44,7 +44,7 @@ function Get-DbaSpinLockStatistic {
         Get SpinLock Statistics for servers sql2008 and sqlserver2012.
 
     .EXAMPLE
-        PS C:\> $output = Get-DbaSpinLockStatistic -SqlInstance sql2008 | Select * | ConvertTo-DbaDataTable
+        PS C:\> $output = Get-DbaSpinLockStatistic -SqlInstance sql2008 | Select-Object * | ConvertTo-DbaDataTable
 
         Collects all SpinLock Statistics on server sql2008 into a Data Table.
 

functions/Get-DbaWaitStatistic.ps1

@@ -60,7 +60,7 @@ function Get-DbaWaitStatistic {
         Check wait statistics on server sql2008 for thresholds above 98% and include wait stats that are most often, but not always, ignorable
 
     .EXAMPLE
-        PS C:\> Get-DbaWaitStatistic -SqlInstance sql2008 | Select *
+        PS C:\> Get-DbaWaitStatistic -SqlInstance sql2008 | Select-Object *
 
         Shows detailed notes, if available, from Paul's post
 

functions/Get-DbaWsfcCluster.ps1

@@ -37,7 +37,7 @@ function Get-DbaWsfcCluster {
         Gets failover cluster information about cluster01
 
     .EXAMPLE
-        PS C:\> Get-DbaWsfcCluster -ComputerName cluster01 | Select *
+        PS C:\> Get-DbaWsfcCluster -ComputerName cluster01 | Select-Object *
 
         Shows all cluster values, including the ones not shown in the default view
 

functions/Get-DbaWsfcNetworkInterface.ps1

@@ -37,7 +37,7 @@ function Get-DbaWsfcNetworkInterface {
         Gets network interface information from the failover cluster cluster01
 
     .EXAMPLE
-        PS C:\> Get-DbaWsfcNetworkInterface -ComputerName cluster01 | Select *
+        PS C:\> Get-DbaWsfcNetworkInterface -ComputerName cluster01 | Select-Object *
 
         Shows all network interface  values, including the ones not shown in the default view
 

functions/Get-DbaWsfcResource.ps1

@@ -37,7 +37,7 @@ function Get-DbaWsfcResource {
         Gets resource information from the failover cluster cluster01
 
     .EXAMPLE
-        PS C:\> Get-DbaWsfcResource -ComputerName cluster01 | Select *
+        PS C:\> Get-DbaWsfcResource -ComputerName cluster01 | Select-Object *
 
         Shows all resource values, including the ones not shown in the default view
 

functions/Get-DbaWsfcRole.ps1

@@ -37,7 +37,7 @@ function Get-DbaWsfcRole {
         Gets role information from the failover cluster cluster01
 
     .EXAMPLE
-        PS C:\> Get-DbaWsfcRole -ComputerName cluster01 | Select *
+        PS C:\> Get-DbaWsfcRole -ComputerName cluster01 | Select-Object *
 
         Shows all role values, including the ones not shown in the default view
 

functions/Import-DbaCsv.ps1

@@ -485,23 +485,22 @@ function Import-DbaCsv {
                 Write-Message -Level Verbose -Message "Starting bulk copy for $(Split-Path $file -Leaf)"
 
                 # Setup bulk copy options
-                $bulkCopyOptions = @()
+                [int]$bulkCopyOptions = ([System.Data.SqlClient.SqlBulkCopyOptions]::Default)
                 $options = "TableLock", "CheckConstraints", "FireTriggers", "KeepIdentity", "KeepNulls", "Default"
                 foreach ($option in $options) {
                     $optionValue = Get-Variable $option -ValueOnly -ErrorAction SilentlyContinue
                     if ($optionValue -eq $true) {
-                        $bulkCopyOptions += "$option"
+                        $bulkCopyOptions = $bulkCopyOptions -bor (Invoke-Expression "[System.Data.SqlClient.SqlBulkCopyOptions]::$option")
                     }
                 }
-                $bulkCopyOptions = $bulkCopyOptions -join " & "
 
                 if ($PSCmdlet.ShouldProcess($instance, "Performing import from $file")) {
                     try {
                         # Create SqlBulkCopy using default options, or options specified in command line.
                         if ($bulkCopyOptions) {
-                            $bulkcopy = New-Object Data.SqlClient.SqlBulkCopy($oleconnstring, $bulkCopyOptions, $transaction)
+                            $bulkcopy = New-Object Data.SqlClient.SqlBulkCopy($sqlconn, $bulkCopyOptions, $transaction)
                         } else {
-                            $bulkcopy = New-Object Data.SqlClient.SqlBulkCopy($sqlconn, "Default", $transaction)
+                            $bulkcopy = New-Object Data.SqlClient.SqlBulkCopy($sqlconn, ([System.Data.SqlClient.SqlBulkCopyOptions]::Default), $transaction)
                         }
 
                         $bulkcopy.DestinationTableName = "[$schema].[$table]"

functions/Remove-DbaDbSnapshot.ps1

@@ -74,7 +74,7 @@ function Remove-DbaDbSnapshot {
         Removes HR_snapshot and Accounting_snapshot
 
     .EXAMPLE
-        PS C:\> Get-DbaDbSnapshot -SqlInstance sql2016 | Where SnapshotOf -like '*dumpsterfire*' | Remove-DbaDbSnapshot
+        PS C:\> Get-DbaDbSnapshot -SqlInstance sql2016 | Where-Object SnapshotOf -like '*dumpsterfire*' | Remove-DbaDbSnapshot
 
         Removes all snapshots associated with databases that have dumpsterfire in the name
 

functions/Remove-DbaSpn.ps1

@@ -56,12 +56,12 @@ function Remove-DbaSpn {
         Connects to Active Directory and removes a provided SPN to the given account. Uses alternative account to connect to AD.
 
     .EXAMPLE
-        PS C:\> Test-DbaSpn -ComputerName sql2005 | Where { $_.isSet -eq $true } | Remove-DbaSpn -WhatIf
+        PS C:\> Test-DbaSpn -ComputerName sql2005 | Where-Object { $_.isSet -eq $true } | Remove-DbaSpn -WhatIf
 
         Shows what would happen trying to remove all set SPNs for sql2005 and the relative delegations
 
     .EXAMPLE
-        PS C:\> Test-DbaSpn -ComputerName sql2005 | Where { $_.isSet -eq $true } | Remove-DbaSpn
+        PS C:\> Test-DbaSpn -ComputerName sql2005 | Where-Object { $_.isSet -eq $true } | Remove-DbaSpn
 
         Removes all set SPNs for sql2005 and the relative delegations
 

functions/Rename-DbaDatabase.ps1

@@ -136,7 +136,7 @@ function Rename-DbaDatabase {
         https://dbatools.io/Rename-DbaDatabase
 
     .EXAMPLE
-        PS C:\> Rename-DbaDatabase -SqlInstance sqlserver2014a -Database HR -DatabaseName HR2 -Preview | select *
+        PS C:\> Rename-DbaDatabase -SqlInstance sqlserver2014a -Database HR -DatabaseName HR2 -Preview | Select-Object *
 
         Shows the detailed result set you'll get renaming the HR database to HR2 without doing anything
 

functions/Set-DbaSpn.ps1

@@ -61,12 +61,12 @@ function Set-DbaSpn {
         Connects to Active Directory and adds a provided SPN to the given account, without the delegation.
 
     .EXAMPLE
-        PS C:\> Test-DbaSpn -ComputerName sql2016 | Where { $_.isSet -eq $false } | Set-DbaSpn
+        PS C:\> Test-DbaSpn -ComputerName sql2016 | Where-Object { $_.isSet -eq $false } | Set-DbaSpn
 
         Sets all missing SPNs for sql2016
 
     .EXAMPLE
-        PS C:\> Test-DbaSpn -ComputerName sql2016 | Where { $_.isSet -eq $false } | Set-DbaSpn -WhatIf
+        PS C:\> Test-DbaSpn -ComputerName sql2016 | Where-Object { $_.isSet -eq $false } | Set-DbaSpn -WhatIf
 
         Displays what would happen trying to set all missing SPNs for sql2016
 

functions/Test-DbaDeprecatedFeature.ps1

@@ -43,7 +43,7 @@ function Test-DbaDeprecatedFeature {
         Check deprecated features on server sql2008 for only the testdb and db2 databases
 
     .EXAMPLE
-        PS C:\> Get-DbaDatabase -SqlInstance sql2008 -Database testdb, db2 | Test-DbaDeprecatedFeature | Select *
+        PS C:\> Get-DbaDatabase -SqlInstance sql2008 -Database testdb, db2 | Test-DbaDeprecatedFeature | Select-Object *
 
         See the object definition in the output as well
 

readme.md

@@ -88,7 +88,7 @@ $startDbaMigrationSplat = @{
     Exclude = 'BackupDevice','SysDbUserObjects','Credentials'
 }
 
-Start-DbaMigration @startDbaMigrationSplat -Force | Select * | Out-GridView
+Start-DbaMigration @startDbaMigrationSplat -Force | Select-Object * | Out-GridView
 
 # Know how snapshots used to be a PITA? Now they're super easy
 New-DbaDbSnapshot -SqlInstance $new -Database db1 -Name db1_snapshot
@@ -101,7 +101,7 @@ Remove-DbaDbSnapshot -SqlInstance $new -Snapshot db1_snapshot # or -Database db1
 $old | Get-DbaLastGoodCheckDb | Out-GridView
 
 # Here's how you can find your integrity jobs and easily start them. Then, you can watch them run, and finally check your newest DBCC CHECKDB results
-$old | Get-DbaAgentJob | Where Name -match integrity | Start-DbaAgentJob
+$old | Get-DbaAgentJob | Where-Object Name -match integrity | Start-DbaAgentJob
 $old | Get-DbaRunningJob
 $old | Get-DbaLastGoodCheckDb | Out-GridView
 
@@ -132,7 +132,7 @@ Invoke-DbaDbClone -SqlInstance $new -Database db1 -CloneDatabase db1_clone | Out
 
 # Read and watch XEvents
 Get-DbaXESession -SqlInstance $new -Session system_health | Read-DbaXEFile
-Get-DbaXESession -SqlInstance $new -Session system_health | Read-DbaXEFile | Select -ExpandProperty Fields | Out-GridView
+Get-DbaXESession -SqlInstance $new -Session system_health | Read-DbaXEFile | Select-Object -ExpandProperty Fields | Out-GridView
 
 # Reset-DbaAdmin
 Reset-DbaAdmin -SqlInstance $instance -Login sqladmin -Verbose

tests/Get-DbaModule.Tests.ps1

@@ -25,11 +25,11 @@ Describe "$CommandName Integration Tests" -Tags "IntegrationTests" {
         # SQL2008R2SP2 will return a number of modules from the msdb database so it is a good candidate to test
         $results = Get-DbaModule -SqlInstance $script:instance1 -Type View -Database msdb
         It "Should only have one type of object" {
-            ($results | Select -Unique Database | Measure-Object).Count | Should Be 1
+            ($results | Select-Object -Unique Database | Measure-Object).Count | Should Be 1
         }
 
         It "Should only have one database" {
-            ($results | Select -Unique Type | Measure-Object).Count | Should Be 1
+            ($results | Select-Object -Unique Type | Measure-Object).Count | Should Be 1
         }
     }
 }

tests/Test-DbaDbRecoveryModel.Tests.ps1

@@ -75,7 +75,7 @@ Describe "$CommandName Intigration Tests" -Tag  "IntegrationTests" {
     }
 
     Context "Psudo Simple Recovery" {
-        $results = Test-DbaDbRecoveryModel -SqlInstance $script:instance2 -RecoveryModel Full | Where {$_.database -eq "$psudoSimpleRecovery"}
+        $results = Test-DbaDbRecoveryModel -SqlInstance $script:instance2 -RecoveryModel Full | Where-Object {$_.database -eq "$psudoSimpleRecovery"}
 
         It "Should return $psudoSimpleRecovery" {
             $results.Database | should -Be "$psudoSimpleRecovery"