Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ImportDbaCsv for non default SqlBulkCopyOptions #5004

Closed
wants to merge 37 commits into from

Conversation

spaghettidba
Copy link
Contributor

Type of Change

  • Bug fix (non-breaking change, fixes #)
  • New feature (non-breaking change, adds functionality)
  • Breaking change (effects multiple commands or functionality)
  • Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
  • Nunit test is included
  • Documentation
  • Build system

Purpose

Fixed Import-DbaCsv when using non default SqlBulkCopyOptions such as KeepNulls and TableLock.
See Issues #4999 and #4998

Approach

The options were passed as strings, but they should have been values from the enum SqlBulkCopyOptions

Commands to test

Import-Dbacsv -SqlInstance SQLCSRV04\SQL2017 -Database Storage -Schema staging -Table DSK_DS8K_I BM_LSARRAY -Path C:\temp\storage\test.txt -Delimiter ";" -KeepNulls -TableLock

potatoqualitee and others added 30 commits December 4, 2018 01:29
Removed function aliases.
0.9.730 - moved transaction inside whatif/shouldprocess
@potatoqualitee
Copy link
Member

thanks a ton for the fixes! will redo the PR 🙇‍♀️

@potatoqualitee potatoqualitee deleted the ImportDbaCsv branch January 23, 2019 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants