Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2.10.x branch for Python 3.12 and beyond #673

Merged

Conversation

rahulrajaram
Copy link

@rahulrajaram rahulrajaram commented Feb 8, 2024

NOTICE: Prior to submitting a pull request, please ensure you abide by the
Guidelines for Code Contributions, including but not limited to:

  • PR is associated with at least one issue: Failure on 2.10.x branch using Python 3.12 #672
  • Submit from a topic branch, not a pre-existing Cement branch: Fix210xBranchForPython312
  • Make every effort to comply with PEP8
  • All tests pass successfully: Yes. I did not add any new tests since the existing tests suffice.
  • Coverage reports 100% code coverage: Since I've added a conditional check for Python version < 3.4 in ext_plugin.py coverage of this file has fallen to 93%. I'm open to suggestions.

Issue: #672

@derks
Copy link
Member

derks commented Feb 8, 2024

@rahulrajaram thank you for the PR. Cement 2.x is very old... Travis tests all fail simply because it was setup to test against older versions of Python (2.7, <3.5). I understand moving to Cement 3.x may not be possible right away however I wanted to stress that Cement 2.x has been unofficially EOL for years and should be moved away from as soon as possible for anything under active development/use.

I am OK with merging this in as long as it doesn't break anything.... but I need to put some work into updating the dev environment for testing.

@rahulrajaram
Copy link
Author

@derks , thanks for your response and clarifying the status of Cement 2.x.

I could take a stab at fixing the dev setup, but could you clarify what versions of Python you intend on supporting with the 2.10.x series. Although I am able to get the tests to pass with 3.7 and 3.12, I am not able to get them to pass with 3.5 because the latest versions of certain cement dependencies won't build. Would you be okay dropping support from Python < 3.7?

@derks derks merged commit a414812 into datafolklabs:stable/2.10.x Feb 9, 2024
1 check failed
@rahulrajaram rahulrajaram deleted the Fix210xBranchForPython312 branch February 9, 2024 18:05
rahulrajaram pushed a commit to aws/aws-elastic-beanstalk-cli that referenced this pull request Feb 20, 2024
…3.12

Cement 2.10.14 avoids importing `imp` in versions of Python it is
deprecated in. This commit upgrades Cement to Python 2.10.14.

See: datafolklabs/cement#673
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants