Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monkeypatch cement/core/foundations to get around imp/importlib issue #510

Closed
wants to merge 1 commit into from

Conversation

rahulrajaram
Copy link
Collaborator

@rahulrajaram rahulrajaram commented Feb 5, 2024

Issue #, if available:
#493

Description of changes:

Cement has fixed several imp vs importlib related changes upstream but there still are some issues in the 2.x series. This commit monkey patches cement/core/foundations.py to get around those problems. This commit should effectively fix the EBCLI for Python 3.12.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Cement has fixed several imp vs importlib related changes upstream but
there still are some issues in the 2.x series. This commit monkey
patches cement/core/foundations.py to get around those problems.
@rahulrajaram rahulrajaram changed the title Monkey cement/core/foundations to get around imp/importlib issue Monkeypatch cement/core/foundations to get around imp/importlib issue Feb 5, 2024
@rahulrajaram
Copy link
Collaborator Author

Fixed upstream in cement: datafolklabs/cement#673

@rahulrajaram rahulrajaram deleted the FixImpVsImportlibIssues1 branch September 14, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant